You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we end up client rendering a boundary due to an error after we have
already injected a postponed hole in that boundary we'll end up trying
to target a missing segment. Since we never insert segments for an
already errored boundary into the HTML. Normally an errored prerender
wouldn't be used but if it is, such as if it was an intentional client
error it triggers this case. Those should really be replaced with
postpones though.
This is a bit annoying since we eagerly build up the postponed path. I
took the easy route here and just cleared out the suspense boundary
itself from having any postponed slots. However, this still creates an
unnecessary replay path along the way to the boundary. We could probably
walk the path and remove any empty parent nodes.
What is worse is that if this is the only thing that postponed, we'd
still generate a postponed state even though there's actually nothing to
resume. Since this is a bit of an edge case already maybe it's fine.
In my test I added a check for the `error` event on `window` since this
error only surfaces by throwing an ignored error. We should really do
that globally for all tests. Our tests should fail by default if there's
an error logged to the window.
DiffTrain build for commit f9dddcb.
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -25524,7 +25524,7 @@ if (__DEV__) {
25524
25524
return root;
25525
25525
}
25526
25526
25527
-
var ReactVersion = "18.3.0-canary-f1039be4a-20240107";
25527
+
var ReactVersion = "18.3.0-canary-f9dddcbbb-20240108";
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9117,7 +9117,7 @@ var devToolsConfig$jscomp$inline_1037 = {
9117
9117
throwError("TestRenderer does not support findFiberByHostInstance()");
9118
9118
},
9119
9119
bundleType: 0,
9120
-
version: "18.3.0-canary-f1039be4a-20240107",
9120
+
version: "18.3.0-canary-f9dddcbbb-20240108",
9121
9121
rendererPackageName: "react-test-renderer"
9122
9122
};
9123
9123
varinternals$jscomp$inline_1230={
@@ -9148,7 +9148,7 @@ var internals$jscomp$inline_1230 = {
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9545,7 +9545,7 @@ var devToolsConfig$jscomp$inline_1079 = {
9545
9545
throwError("TestRenderer does not support findFiberByHostInstance()");
9546
9546
},
9547
9547
bundleType: 0,
9548
-
version: "18.3.0-canary-f1039be4a-20240107",
9548
+
version: "18.3.0-canary-f9dddcbbb-20240108",
9549
9549
rendererPackageName: "react-test-renderer"
9550
9550
};
9551
9551
varinternals$jscomp$inline_1271={
@@ -9576,7 +9576,7 @@ var internals$jscomp$inline_1271 = {
0 commit comments