Skip to content

Commit 05a55a4

Browse files
josepharhargaearon
andauthored
Fix change events for custom elements (#22938)
* Bypass react event system for custom elements * Going to try fixing react event system instead * finally got it to call onChange, but perhaps too many times * update test * Removed ReactDOMComponent changes, now works but still doubles for bubbles * Maybe i should only support bubbling events * removed some old stuff * cleaned up changeeventplugin stuff * prettier, lint * removed changeeventplugin stuff * remove unneeded gate for onInput test * Go back to using ChangeEventPlugin * Add input+change test * lint * Move logic to shouldUseChangeEvent * use memoizedProps instead of pendingProps * Run form control behavior before custom element behavior * add bubbling test * forgot to append container to body * add child event target test * expand <input is=...> test expectations * Make tests more realistic * Add extra test * Add missing gating * Actually fix gating Co-authored-by: Dan Abramov <[email protected]>
1 parent d8cfeaf commit 05a55a4

File tree

2 files changed

+591
-1
lines changed

2 files changed

+591
-1
lines changed

0 commit comments

Comments
 (0)