Add deleteProperty API #52911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tsaichien wants to merge 1 commit into facebook:main from tsaichien:export-D79120814

+154 −0

Contributor

tsaichien commented Jul 29, 2025

Summary:
Add a new deleteProperty API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses Reflect.deleteProperty. For the
PropNameID overload, convert the propNameID to a String and pass into
the deleteProperty function.

Changelog: [Internal]

Differential Revision: D79120814

meta-cla bot added the CLA Signed label

facebook-github-bot added p: Facebook Partner labels

Contributor

facebook-github-bot commented Jul 29, 2025

This pull request was exported from Phabricator. Differential Revision: D79120814

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Jul 29, 2025

This pull request was exported from Phabricator. Differential Revision: D79120814

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

2dd3c83

Summary:
Pull Request resolved: facebook#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Differential Revision: D79120814

tsaichien force-pushed the export-D79120814 branch from 1a74b94 to 2dd3c83 Compare

July 29, 2025 19:45

Contributor

facebook-github-bot commented Jul 29, 2025

This pull request was exported from Phabricator. Differential Revision: D79120814

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

f43ae9d

Summary:
Pull Request resolved: facebook#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Differential Revision: D79120814

tsaichien force-pushed the export-D79120814 branch from 2dd3c83 to f43ae9d Compare

July 29, 2025 19:52

tsaichien force-pushed the export-D79120814 branch from f43ae9d to a353b9e Compare

August 8, 2025 19:03

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

a353b9e

Summary:

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Differential Revision: D79120814

Contributor

facebook-github-bot commented Aug 8, 2025

This pull request was exported from Phabricator. Differential Revision: D79120814

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

b5bde4d

Summary:
Pull Request resolved: facebook#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Differential Revision: D79120814

tsaichien force-pushed the export-D79120814 branch 2 times, most recently from b5bde4d to 28fab62 Compare

August 15, 2025 17:55

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

28fab62

Summary:

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Differential Revision: D79120814

Contributor

facebook-github-bot commented Aug 15, 2025

This pull request was exported from Phabricator. Differential Revision: D79120814

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

4c3a313

Summary:
Pull Request resolved: facebook#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Differential Revision: D79120814

tsaichien force-pushed the export-D79120814 branch from 28fab62 to 4c3a313 Compare

August 15, 2025 18:00

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

f255e3f

Summary:

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Differential Revision: D79120814

tsaichien force-pushed the export-D79120814 branch from 4c3a313 to f255e3f Compare

August 15, 2025 20:24

Contributor

facebook-github-bot commented Aug 15, 2025

This pull request was exported from Phabricator. Differential Revision: D79120814

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

9862f0f

Summary:
Pull Request resolved: facebook#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Differential Revision: D79120814

tsaichien force-pushed the export-D79120814 branch 2 times, most recently from 9862f0f to 0356962 Compare

August 18, 2025 21:37

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

Summary:

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Reviewed By: dannysu

Differential Revision: D79120814

Contributor

facebook-github-bot commented Aug 18, 2025

This pull request was exported from Phabricator. Differential Revision: D79120814

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

d371943

Summary:
Pull Request resolved: facebook#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Reviewed By: dannysu

Differential Revision: D79120814

tsaichien force-pushed the export-D79120814 branch 2 times, most recently from d371943 to 210bfb5 Compare

August 21, 2025 21:30

tsaichien added a commit to tsaichien/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

210bfb5

Summary:

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Reviewed By: dannysu

Differential Revision: D79120814


          Add deleteProperty API (facebook#52911)

e1df919

Summary:
Pull Request resolved: facebook#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Reviewed By: dannysu

Differential Revision: D79120814

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D79120814

tsaichien force-pushed the export-D79120814 branch from 210bfb5 to e1df919 Compare

August 21, 2025 21:33

facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request


          Add deleteProperty API

Summary:
X-link: facebook/react-native#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Reviewed By: dannysu

Differential Revision: D79120814

fbshipit-source-id: e30f383247d94bb5971e4909f004c75e8165adda

facebook-github-bot closed this in

646945c

Collaborator

react-native-bot commented Aug 22, 2025

This pull request was successfully merged by @tsaichien in 646945c

^{When will my fix make it into a release? | How to file a pick request?}

react-native-bot added the Merged label

Contributor

facebook-github-bot commented Aug 22, 2025

This pull request has been merged in 646945c.

facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request


          Add deleteProperty API

195afcf

Summary:
X-link: facebook/react-native#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Reviewed By: dannysu

Differential Revision: D79120814

fbshipit-source-id: e30f383247d94bb5971e4909f004c75e8165adda

kikoso pushed a commit to kikoso/react-native that referenced this pull request


          Add deleteProperty API (facebook#52911)

35198ef

Summary:
Pull Request resolved: facebook#52911

Add a new `deleteProperty` API to JSI. As the name implies, allows users
to delete properties from Objects through JSI.

The default implementation uses `Reflect.deleteProperty.` For the
`PropNameID` overload, convert the propNameID to a String and pass into
the `deleteProperty` function.

Changelog: [Internal]

Reviewed By: dannysu

Differential Revision: D79120814

fbshipit-source-id: e30f383247d94bb5971e4909f004c75e8165adda

Contributor

mrousavy commented Sep 26, 2025

Hey - we don't have jsi::Object::defineProperty yet, do we?

If not I could take a stab at implementing that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner