Skip to content

Commit f2c6877

Browse files
sherginfacebook-github-bot
authored andcommitted
Fixed crash on attempt to update local data of deallocated shadow node
Summary: Trivial. That's okay that sometimes shadowNodes and views hierarchies have lack of synchonization. Reviewed By: sahrens Differential Revision: D6040022 fbshipit-source-id: 6b49a82317b620b66a87441719fddcafb1f27934
1 parent 452ac1b commit f2c6877

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

ReactAndroid/src/main/java/com/facebook/react/uimanager/UIImplementation.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,10 @@ public void setViewLocalData(int tag, Object data) {
243243
ReactShadowNode shadowNode = mShadowNodeRegistry.getNode(tag);
244244

245245
if (shadowNode == null) {
246-
throw new IllegalViewOperationException(
247-
"Trying to set local data for view with unknown tag: " + tag);
246+
FLog.w(
247+
ReactConstants.TAG,
248+
"Attempt to set local data for view with unknown tag: " + tag);
249+
return;
248250
}
249251

250252
shadowNode.setLocalData(data);

0 commit comments

Comments
 (0)