Skip to content

Commit bc749a1

Browse files
genkikondofacebook-github-bot
authored andcommitted
Early exit during matching in EventAnimationDriverMatchSpec
Summary: Simple optimization to exit before iterating through the hit path if the event name doesn't match. Changelog: [Android][Internal] - Optimization for natively-driven Animated PointerEvents to early exit during matching in EventAnimationDriverMatchSpec. This should have no effect if you are not using PointerEvents Reviewed By: lunaleaps Differential Revision: D43400457 fbshipit-source-id: fe8d811d371c78622cd4f3f9cd469cff9ccce585
1 parent 407fb5c commit bc749a1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ReactAndroid/src/main/java/com/facebook/react/uimanager/events/PointerEvent.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,14 +124,14 @@ public Event.EventAnimationDriverMatchSpec getEventAnimationDriverMatchSpec() {
124124
new EventAnimationDriverMatchSpec() {
125125
@Override
126126
public boolean match(int viewTag, String eventName) {
127-
if (!PointerEventHelper.isBubblingEvent(eventName)) {
127+
if (!eventName.equals(mEventName) || !PointerEventHelper.isBubblingEvent(eventName)) {
128128
return false;
129129
}
130130

131131
List<TouchTargetHelper.ViewTarget> viewTargets =
132132
mEventState.getHitPathForActivePointer();
133133
for (TouchTargetHelper.ViewTarget viewTarget : viewTargets) {
134-
if (viewTarget.getViewId() == viewTag && eventName.equals(mEventName)) {
134+
if (viewTarget.getViewId() == viewTag) {
135135
return true;
136136
}
137137
}

0 commit comments

Comments
 (0)