Skip to content

Commit 70b735c

Browse files
dulmandakhfacebook-github-bot
authored andcommitted
extract and reuse ANDROIDX_TEST_VERSION (#26487)
Summary: This PR is extracts and reuses ANDROIDX_TEST_VERSION, and is part of Gradle script refactoring effort. ## Changelog [Android] [Changed] - extract and reuse ANDROIDX_TEST_VERSION Pull Request resolved: #26487 Differential Revision: D17488766 Pulled By: mdvacca fbshipit-source-id: f1968ffc403074d78d792eb5cc773cc6366ad2d1
1 parent f054928 commit 70b735c

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

ReactAndroid/build.gradle

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -380,9 +380,8 @@ dependencies {
380380
testImplementation("org.robolectric:robolectric:${ROBOLECTRIC_VERSION}")
381381

382382
androidTestImplementation(fileTree(dir: "src/main/third-party/java/buck-android-support/", include: ["*.jar"]))
383-
//TODO: Refactor to extract versions of androidx dependencies
384-
androidTestImplementation("androidx.test:runner:1.1.0")
385-
androidTestImplementation("androidx.test:rules:1.1.0")
383+
androidTestImplementation("androidx.test:runner:${ANDROIDX_TEST_VERSION}")
384+
androidTestImplementation("androidx.test:rules:${ANDROIDX_TEST_VERSION}")
386385
androidTestImplementation("org.mockito:mockito-core:${MOCKITO_CORE_VERSION}")
387386
}
388387

ReactAndroid/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ ROBOLECTRIC_VERSION=3.0
1111
JUNIT_VERSION=4.12
1212
FEST_ASSERT_CORE_VERSION=2.0M10
1313

14-
ANDROID_SUPPORT_TEST_VERSION=1.0.2
14+
ANDROIDX_TEST_VERSION=1.1.0
1515
FRESCO_VERSION=2.0.0
1616
OKHTTP_VERSION=3.12.1
1717
SO_LOADER_VERSION=0.6.0

0 commit comments

Comments
 (0)