Fix race condition in SurfaceHandler (#37088)

Summary:
Pull Request resolved: #37088

changelog: [internal]

This is a race condition. parameters need to be copied out, otherwise they might be changed during read.

Reviewed By: luluwu2032

Differential Revision: D45272086

fbshipit-source-id: 9043762dfaaf61d08e187c0d83f743e991a94ed1

Author: sammy-SC

packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp

@@ -112,13 +112,15 @@ void SurfaceHandler::stop() const noexcept {
 }
 
 void SurfaceHandler::setDisplayMode(DisplayMode displayMode) const noexcept {
+  auto parameters = Parameters{};
   {
     std::unique_lock lock(parametersMutex_);
     if (parameters_.displayMode == displayMode) {
       return;
     }
 
     parameters_.displayMode = displayMode;
+    parameters = parameters_;
   }
 
   {
@@ -129,10 +131,10 @@ void SurfaceHandler::setDisplayMode(DisplayMode displayMode) const noexcept {
     }
 
     link_.uiManager->setSurfaceProps(
-        parameters_.surfaceId,
-        parameters_.moduleName,
-        parameters_.props,
-        parameters_.displayMode);
+        parameters.surfaceId,
+        parameters.moduleName,
+        parameters.props,
+        parameters.displayMode);
 
     applyDisplayMode(displayMode);
   }