Skip to content

Commit 548549e

Browse files
committed
[style] expose rotate x, y, z transforms
Summary: Added rotateX, rotateY, rotateZ transforms. cc @sahrens Closes #1976 Github Author: chirag04 <[email protected]>
1 parent 19ddbac commit 548549e

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

Libraries/StyleSheet/TransformPropTypes.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ var TransformPropTypes = {
1717
transform: ReactPropTypes.arrayOf(
1818
ReactPropTypes.oneOfType([
1919
ReactPropTypes.shape({rotate: ReactPropTypes.string}),
20+
ReactPropTypes.shape({rotateX: ReactPropTypes.string}),
21+
ReactPropTypes.shape({rotateY: ReactPropTypes.string}),
22+
ReactPropTypes.shape({rotateZ: ReactPropTypes.string}),
23+
ReactPropTypes.shape({scale: ReactPropTypes.number}),
2024
ReactPropTypes.shape({scaleX: ReactPropTypes.number}),
2125
ReactPropTypes.shape({scaleY: ReactPropTypes.number}),
2226
ReactPropTypes.shape({translateX: ReactPropTypes.number}),

Libraries/StyleSheet/precomputeStyle.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,14 @@ function _precomputeTransforms(style: Object): Object {
5858
case 'matrix':
5959
MatrixMath.multiplyInto(result, result, value);
6060
break;
61+
case 'rotateX':
62+
_multiplyTransform(result, MatrixMath.reuseRotateXCommand, [_convertToRadians(value)]);
63+
break;
64+
case 'rotateY':
65+
_multiplyTransform(result, MatrixMath.reuseRotateYCommand, [_convertToRadians(value)]);
66+
break;
6167
case 'rotate':
68+
case 'rotateZ':
6269
_multiplyTransform(result, MatrixMath.reuseRotateZCommand, [_convertToRadians(value)]);
6370
break;
6471
case 'scale':
@@ -156,6 +163,9 @@ function _validateTransform(key, value, transformation) {
156163
break;
157164
case 'translate':
158165
break;
166+
case 'rotateX':
167+
case 'rotateY':
168+
case 'rotateZ':
159169
case 'rotate':
160170
invariant(
161171
typeof value === 'string',

0 commit comments

Comments
 (0)