Use react-native's public interface where possible

Instead of requiring specific files and bypassing the public interface, require react-native's exports where possible instead.

Author: ide

RNTester/RCTTest/RCTSnapshotNativeComponent.js

@@ -10,6 +10,8 @@
 
 'use strict';
 
+const {requireNativeComponent} = require('react-native');
+
 import type {SyntheticEvent} from '../../Libraries/Types/CoreEventTypes';
 import type {ViewProps} from '../../Libraries/Components/View/ViewPropTypes';
 import type {NativeComponent} from '../../Libraries/Renderer/shims/ReactNative';
@@ -28,8 +30,6 @@ type NativeProps = $ReadOnly<{|
 
 type SnapshotViewNativeType = Class<NativeComponent<NativeProps>>;
 
-const requireNativeComponent = require('../../Libraries/ReactNative/requireNativeComponent');
-
 module.exports = ((requireNativeComponent(
   'RCTSnapshot',
 ): any): SnapshotViewNativeType);

RNTester/js/ARTExample.js

@@ -11,8 +11,7 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
-const {ART, Platform, View} = ReactNative;
+const {ART, Platform, View} = require('react-native');
 
 const {Surface, Path, Group, Shape} = ART;
 

RNTester/js/AccessibilityAndroidExample.android.js

@@ -10,15 +10,12 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
 const {
-  AccessibilityInfo,
   StyleSheet,
   Text,
   View,
-  ToastAndroid,
   TouchableWithoutFeedback,
-} = ReactNative;
+} = require('react-native');
 
 const RNTesterBlock = require('./RNTesterBlock');
 const RNTesterPage = require('./RNTesterPage');

RNTester/js/AccessibilityExample.js

@@ -10,8 +10,13 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
-const {AccessibilityInfo, Text, View, TouchableOpacity, Alert} = ReactNative;
+const {
+  AccessibilityInfo,
+  Text,
+  View,
+  TouchableOpacity,
+  Alert,
+} = require('react-native');
 
 const RNTesterBlock = require('./RNTesterBlock');
 

RNTester/js/AccessibilityIOSExample.js

@@ -11,8 +11,7 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
-const {AccessibilityInfo, Text, View, TouchableOpacity, Alert} = ReactNative;
+const {Text, View, Alert} = require('react-native');
 
 const RNTesterBlock = require('./RNTesterBlock');
 
@@ -34,7 +33,9 @@ class AccessibilityIOSExample extends React.Component<Props> {
           <Text>Accessibility magic tap example</Text>
         </View>
         <View
-          onAccessibilityEscape={() => alert('onAccessibilityEscape success')}
+          onAccessibilityEscape={() =>
+            Alert.alert('onAccessibilityEscape success')
+          }
           accessible={true}>
           <Text>Accessibility escape example</Text>
         </View>

RNTester/js/ActionSheetIOSExample.js

@@ -11,15 +11,15 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
 const {
   ActionSheetIOS,
   StyleSheet,
   Text,
   View,
   Alert,
   NativeModules,
-} = ReactNative;
+  findNodeHandle,
+} = require('react-native');
 const ScreenshotManager = NativeModules.ScreenshotManager;
 
 const BUTTONS = ['Option 0', 'Option 1', 'Option 2', 'Delete', 'Cancel'];
@@ -128,7 +128,7 @@ class ActionSheetAnchorExample extends React.Component<
         cancelButtonIndex: CANCEL_INDEX,
         destructiveButtonIndex: DESTRUCTIVE_INDEX,
         anchor: this.anchorRef.current
-          ? ReactNative.findNodeHandle(this.anchorRef.current)
+          ? findNodeHandle(this.anchorRef.current)
           : undefined,
       },
       buttonIndex => {
@@ -263,7 +263,7 @@ class ShareScreenshotAnchorExample extends React.Component<
             url: uri,
             excludedActivityTypes: ['com.apple.UIKit.activity.PostToTwitter'],
             anchor: this.anchorRef.current
-              ? ReactNative.findNodeHandle(this.anchorRef.current)
+              ? findNodeHandle(this.anchorRef.current)
               : undefined,
           },
           error => Alert.alert('Error', error),

RNTester/js/AlertExample.js

@@ -10,8 +10,13 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
-const {Alert, StyleSheet, Text, TouchableHighlight, View} = ReactNative;
+const {
+  Alert,
+  StyleSheet,
+  Text,
+  TouchableHighlight,
+  View,
+} = require('react-native');
 
 const RNTesterBlock = require('./RNTesterBlock');
 

RNTester/js/AlertIOSExample.js

@@ -11,8 +11,13 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
-const {StyleSheet, View, Text, TouchableHighlight, Alert} = ReactNative;
+const {
+  StyleSheet,
+  View,
+  Text,
+  TouchableHighlight,
+  Alert,
+} = require('react-native');
 
 const {SimpleAlertExampleBlock} = require('./AlertExample');
 

RNTester/js/AnimatedExample.js

@@ -11,8 +11,7 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
-const {Animated, Easing, StyleSheet, Text, View} = ReactNative;
+const {Animated, Easing, StyleSheet, Text, View} = require('react-native');
 const RNTesterButton = require('./RNTesterButton');
 
 const styles = StyleSheet.create({

RNTester/js/AnimatedGratuitousApp/AnExApp.js

@@ -11,8 +11,13 @@
 'use strict';
 
 const React = require('react');
-const ReactNative = require('react-native');
-const {Animated, LayoutAnimation, PanResponder, StyleSheet, View} = ReactNative;
+const {
+  Animated,
+  LayoutAnimation,
+  PanResponder,
+  StyleSheet,
+  View,
+} = require('react-native');
 
 const AnExSet = require('./AnExSet');