Remove legacy validation warning infra (#53792)

Summary:
Pull Request resolved: #53792

This validation infra served us well, but it's no longer needed.

All the legacy architecture classes have been identified and deprecated. And in the next major release, we will simply remove them.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D82470292

fbshipit-source-id: 44b58e63b7aca4fa22ac6b891275417bf1add8d1

Author: RSNara

packages/react-native/React/Base/RCTAssert.h

@@ -174,43 +174,3 @@ RCT_EXTERN NSString *RCTFormatStackTrace(NSArray<NSDictionary<NSString *, id> *>
   } while (0)
 
 #endif
-
-// MARK: - New Architecture Validation
-
-typedef enum {
-  RCTNotAllowedInBridgeless = 1,
-  RCTNotAllowedInFabricWithoutLegacy = 2,
-  RCTNotAllowedValidationDisabled = 3,
-} RCTNotAllowedValidation;
-
-/**
- * // TODO: (T125626909) Only validate legacy architecture usages in Bridgeless mode, not Bridged Fabric mode
- *
- * Ensure runtime assumptions holds for the new architecture by reporting when assumptions are violated.
- * Note: this is work in progress.
- *
- * When level is RCTNotAllowedInFabricWithoutLegacy, validate Fabric assumptions.
- * i.e. Report legacy pre-Fabric call sites that should not be used while Fabric is enabled on all surfaces.
- *
- * When level is RCTNotAllowedInBridgeless, validate Fabric or Bridgeless assumptions.
- * i.e. Report Bridge call sites that should not be used while Bridgeless mode is enabled.
- *
- * Note: enabling this at runtime is not early enough to report issues within ObjC class +load execution.
- */
-__attribute__((used)) RCT_EXTERN void RCTNewArchitectureSetMinValidationLevel(RCTNotAllowedValidation level);
-
-// When new architecture validation reporting is enabled, trigger an assertion and crash.
-__attribute__((used)) RCT_EXTERN void
-RCTEnforceNewArchitectureValidation(RCTNotAllowedValidation type, id context, NSString *extra);
-// When new architecture validation reporting is enabled, trigger an error but do not crash.
-// When ready, switch to stricter variant above.
-__attribute__((used)) RCT_EXTERN void
-RCTErrorNewArchitectureValidation(RCTNotAllowedValidation type, id context, NSString *extra);
-// When new architecture validation reporting is enabled, log an message.
-// When ready, switch to stricter variant above.
-__attribute__((used)) RCT_EXTERN void
-RCTLogNewArchitectureValidation(RCTNotAllowedValidation type, id context, NSString *extra);
-// A placeholder for callsites that frequently fail validation.
-// When ready, switch to stricter variant above.
-__attribute__((used)) RCT_EXTERN void
-RCTNewArchitectureValidationPlaceholder(RCTNotAllowedValidation type, id context, NSString *extra);

packages/react-native/React/Base/RCTAssert.m

@@ -231,115 +231,3 @@ RCTFatalExceptionHandler RCTGetFatalExceptionHandler(void)
 {
   return RCTCurrentFatalExceptionHandler;
 }
-
-// MARK: - New Architecture Validation - Enable Reporting
-
-#if RCT_ONLY_NEW_ARCHITECTURE_EXPERIMENTAL_DO_NOT_USE
-static RCTNotAllowedValidation minValidationLevel = RCTNotAllowedInBridgeless;
-#else
-static RCTNotAllowedValidation minValidationLevel = RCTNotAllowedValidationDisabled;
-#endif
-
-__attribute__((used)) RCT_EXTERN void RCTNewArchitectureSetMinValidationLevel(RCTNotAllowedValidation level)
-{
-#if RCT_ONLY_NEW_ARCHITECTURE_EXPERIMENTAL_DO_NOT_USE
-  // Cannot disable the reporting in this mode.
-#else
-  minValidationLevel = level;
-#endif
-}
-
-// MARK: - New Architecture Validation - Private
-
-static BOOL shouldEnforceValidation(RCTNotAllowedValidation type)
-{
-  return type >= minValidationLevel;
-}
-
-static NSString *stringDescribingContext(id context)
-{
-  if ([context isKindOfClass:NSString.class]) {
-    return context;
-  } else if (context) {
-    Class klass = [context class];
-    if (klass) {
-      return NSStringFromClass(klass);
-    }
-  }
-  return @"uncategorized";
-}
-
-static NSString *validationMessage(RCTNotAllowedValidation type, id context, NSString *extra)
-{
-  NSString *notAllowedType;
-  switch (type) {
-    case RCTNotAllowedValidationDisabled:
-      RCTAssert(0, @"RCTNotAllowedValidationDisabled not a validation type.");
-      return nil;
-    case RCTNotAllowedInFabricWithoutLegacy:
-      notAllowedType = @"Fabric";
-      break;
-    case RCTNotAllowedInBridgeless:
-      notAllowedType = @"Bridgeless";
-      break;
-  }
-
-  return
-      [NSString stringWithFormat:@"[ReactNative Architecture][NotAllowedIn%@] Unexpectedly reached code path in %@. %@",
-                                 notAllowedType,
-                                 stringDescribingContext(context),
-                                 extra ?: @""];
-}
-
-static void
-newArchitectureValidationInternal(RCTLogLevel level, RCTNotAllowedValidation type, id context, NSString *extra)
-{
-  if (!shouldEnforceValidation(type)) {
-    return;
-  }
-
-  NSString *msg = validationMessage(type, context, extra);
-  if (msg) {
-    switch (level) {
-      case RCTLogLevelInfo:
-        RCTLogInfo(@"%@", msg);
-        break;
-      case RCTLogLevelError:
-        RCTLogError(@"%@", msg);
-        break;
-      case RCTLogLevelFatal:
-        RCTAssert(0, @"%@", msg);
-        break;
-      default:
-        RCTAssert(0, @"New architecture validation is only for info, error, and fatal levels.");
-    }
-  }
-}
-
-// MARK: - New Architecture Validation - Public
-
-void RCTEnforceNewArchitectureValidation(RCTNotAllowedValidation type, id context, NSString *extra)
-{
-  newArchitectureValidationInternal(RCTLogLevelFatal, type, context, extra);
-}
-
-void RCTErrorNewArchitectureValidation(RCTNotAllowedValidation type, id context, NSString *extra)
-{
-#if RCT_ONLY_NEW_ARCHITECTURE_EXPERIMENTAL_DO_NOT_USE
-  newArchitectureValidationInternal(RCTLogLevelFatal, type, context, extra);
-#else
-  newArchitectureValidationInternal(RCTLogLevelError, type, context, extra);
-#endif
-}
-
-void RCTLogNewArchitectureValidation(RCTNotAllowedValidation type, id context, NSString *extra)
-{
-  newArchitectureValidationInternal(RCTLogLevelInfo, type, context, extra);
-}
-
-void RCTNewArchitectureValidationPlaceholder(RCTNotAllowedValidation type, id context, NSString *extra)
-{
-#if RCT_ONLY_NEW_ARCHITECTURE_EXPERIMENTAL_DO_NOT_USE
-  newArchitectureValidationInternal(RCTLogLevelInfo, type, context, extra);
-#endif
-}

packages/react-native/React/Base/RCTBridge.mm

@@ -386,7 +386,6 @@ - (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate
 #endif
 
   if (self = [super init]) {
-    RCTEnforceNewArchitectureValidation(RCTNotAllowedInBridgeless, self, nil);
     _delegate = delegate;
     _bundleURL = bundleURL;
     _moduleProvider = block;

packages/react-native/React/Base/RCTDefines.h

@@ -175,13 +175,3 @@
     @throw _RCTNotImplementedException(_cmd, [self class]);                                             \
   }                                                                                                     \
   _Pragma("clang diagnostic pop")
-
-/**
- * Controls for activating the new architecture without the legacy system.
- * Note: this is work in progress.
- */
-#ifdef REACT_NATIVE_FORCE_NEW_ARCHITECTURE_EXPERIMENTAL_DO_NOT_USE
-#define RCT_ONLY_NEW_ARCHITECTURE_EXPERIMENTAL_DO_NOT_USE 1
-#else
-#define RCT_ONLY_NEW_ARCHITECTURE_EXPERIMENTAL_DO_NOT_USE 0
-#endif

packages/react-native/React/Base/Surface/RCTSurface.mm

@@ -67,7 +67,6 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge
                     moduleName:(NSString *)moduleName
              initialProperties:(NSDictionary *)initialProperties
 {
-  RCTErrorNewArchitectureValidation(RCTNotAllowedInFabricWithoutLegacy, @"RCTSurface", nil);
   RCTAssert(bridge.valid, @"Valid bridge is required to instantiate `RCTSurface`.");
 
   if (self = [super init]) {

packages/react-native/React/CoreModules/RCTLogBoxView.mm

@@ -38,8 +38,6 @@ - (void)createRootViewController:(UIView *)view
 #ifndef RCT_REMOVE_LEGACY_ARCH
 - (instancetype)initWithWindow:(UIWindow *)window bridge:(RCTBridge *)bridge
 {
-  RCTErrorNewArchitectureValidation(RCTNotAllowedInFabricWithoutLegacy, @"RCTLogBoxView", nil);
-
   self = [super initWithWindowScene:window.windowScene];
 
   self.windowLevel = UIWindowLevelStatusBar - 1;

packages/react-native/React/Fabric/Mounting/RCTComponentViewFactory.mm

@@ -152,14 +152,6 @@ - (void)_registerComponentIfPossible:(const std::string &)name
   // Fallback 3: Try to use Paper Interop.
   // TODO(T174674274): Implement lazy loading of legacy view managers in the new architecture.
   if (RCTFabricInteropLayerEnabled() && [RCTLegacyViewManagerInteropComponentView isSupported:componentNameString]) {
-    RCTLogNewArchitectureValidation(
-        RCTNotAllowedInBridgeless,
-        self,
-        [NSString
-            stringWithFormat:
-                @"Legacy ViewManagers should be migrated to Fabric ComponentViews in the new architecture to reduce risk. Component using interop layer: %@",
-                componentNameString]);
-
     auto flavor = std::make_shared<const std::string>(name);
     auto componentName = ComponentName{flavor->c_str()};
     auto componentHandle = reinterpret_cast<ComponentHandle>(componentName);

packages/react-native/React/Modules/RCTUIManager.mm

@@ -246,9 +246,6 @@ - (NSMapTable *)nativeIDRegistry
 
 - (void)setBridge:(RCTBridge *)bridge
 {
-  RCTEnforceNewArchitectureValidation(
-      RCTNotAllowedInBridgeless, self, @"RCTUIManager must not be initialized for the new architecture");
-
   RCTAssert(_bridge == nil, @"Should not re-use same UIManager instance");
   _bridge = bridge;
 
@@ -1624,8 +1621,6 @@ - (void)rootViewForReactTag:(NSNumber *)reactTag withCompletion:(void (^)(UIView
 
 + (UIView *)JSResponder
 {
-  RCTErrorNewArchitectureValidation(
-      RCTNotAllowedInFabricWithoutLegacy, @"RCTUIManager", @"Please migrate this legacy surface to Fabric.");
   return _jsResponder;
 }
 

packages/react-native/React/Views/RCTViewManager.m

@@ -137,8 +137,6 @@ - (dispatch_queue_t)methodQueue
 
 - (void)setBridge:(RCTBridge *)bridge
 {
-  RCTErrorNewArchitectureValidation(
-      RCTNotAllowedInBridgeless, self, @"RCTViewManager must not be initialized for the new architecture");
   _bridge = bridge;
 }