From b3c703762d570d71d5a75e615bc2b2d2347037df Mon Sep 17 00:00:00 2001 From: TJ Yin Date: Wed, 14 May 2025 11:46:37 -0700 Subject: [PATCH] Migrate OSS project to handle protocol split Summary: X-link: https://github.com/facebook/CacheLib/pull/386 X-link: https://github.com/facebook/fb303/pull/67 fbthrift has moved compact/binary protocol instantiation outside _types.cpp (to _types_compact.cpp and _types_binary.cpp). We need to add these two files to the build system. Differential Revision: D74687663 --- ThriftLibrary.cmake | 2 ++ build/fbcode_builder/CMake/FBThriftCppLibrary.cmake | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ThriftLibrary.cmake b/ThriftLibrary.cmake index a09903d3b67..a549b4ef13b 100644 --- a/ThriftLibrary.cmake +++ b/ThriftLibrary.cmake @@ -208,6 +208,8 @@ macro(thrift_generate ${output_path}/gen-${language}/${file_name}_constants.cpp ${output_path}/gen-${language}/${file_name}_data.cpp ${output_path}/gen-${language}/${file_name}_types.cpp + ${output_path}/gen-${language}/${file_name}_types_compact.cpp + ${output_path}/gen-${language}/${file_name}_types_binary.cpp ) foreach(service ${services}) set("${file_name}-${language}-HEADERS" diff --git a/build/fbcode_builder/CMake/FBThriftCppLibrary.cmake b/build/fbcode_builder/CMake/FBThriftCppLibrary.cmake index 7147fada232..e29e7921f62 100644 --- a/build/fbcode_builder/CMake/FBThriftCppLibrary.cmake +++ b/build/fbcode_builder/CMake/FBThriftCppLibrary.cmake @@ -69,6 +69,8 @@ function(add_fbthrift_cpp_library LIB_NAME THRIFT_FILE) "${output_dir}/gen-cpp2/${base}_data.h" "${output_dir}/gen-cpp2/${base}_data.cpp" "${output_dir}/gen-cpp2/${base}_types.cpp" + "${output_dir}/gen-cpp2/${base}_types_compact.cpp" + "${output_dir}/gen-cpp2/${base}_types_binary.cpp" "${output_dir}/gen-cpp2/${base}_metadata.cpp" ) foreach(service IN LISTS ARG_SERVICES)