Log debug messages using debug() instead of console.log()

Reviewed By: avp

Differential Revision: D15029492

fbshipit-source-id: 2bfbe769f3623c8308050cdb11ebd6f9334bccaf

Author: Hypuk

package.json

@@ -19,6 +19,7 @@
     "chalk": "^2.4.1",
     "chokidar": "^2.0.4",
     "codecov": "^2.2.0",
+    "debug": "^2.2.0",
     "eslint": "5.1.0",
     "eslint-config-fb-strict": "22.1.0",
     "eslint-plugin-babel": "^5.2.1",

packages/metro-inspector-proxy/package.json

@@ -17,8 +17,8 @@
   ],
   "license": "MIT",
   "dependencies": {
-    "chalk": "^2.4.1",
     "connect": "^3.6.5",
+    "debug": "^2.2.0",
     "rxjs": "^5.4.3",
     "ws": "^1.1.5",
     "yargs": "^9.0.0"

packages/metro-inspector-proxy/src/Device.js

@@ -16,7 +16,7 @@ import WS from 'ws';
 
 const PAGES_POLLING_INTERVAL = 1000;
 
-const chalk = require('chalk');
+const debug = require('debug')('Metro:InspectorProxy');
 
 // Android's stock emulator and other emulators such as genymotion use a standard localhost alias.
 const EMULATOR_LOCALHOST_ADDRESSES: Array<string> = ['10.0.2.2', '10.0.3.2'];
@@ -64,8 +64,7 @@ class Device {
     this._deviceSocket.on('message', (message: string) => {
       const parsedMessage = JSON.parse(message);
       if (parsedMessage.event !== 'getPages') {
-        // eslint-disable-next-line no-console
-        console.log(chalk.yellow('<- From device: ' + message));
+        debug('<- From device: ' + message);
       }
       this._handleMessageFromDevice(parsedMessage);
     });
@@ -96,10 +95,7 @@ class Device {
       socket,
     };
     this._debuggerConnections.set(pageId, debuggerInfo);
-    // eslint-disable-next-line no-console
-    console.log(
-      `Got new debugger connection for page ${pageId} of ${this._name}`,
-    );
+    debug(`Got new debugger connection for page ${pageId} of ${this._name}`);
 
     this._sendMessageToDevice({
       event: 'connect',
@@ -109,8 +105,7 @@ class Device {
     });
 
     socket.on('message', (message: string) => {
-      // eslint-disable-next-line no-console
-      console.log(chalk.green('<- From debugger: ' + message));
+      debug('<- From debugger: ' + message);
       const parsedMessage = JSON.parse(message);
       this._processMessageFromDebugger(parsedMessage, debuggerInfo);
 
@@ -123,10 +118,7 @@ class Device {
       });
     });
     socket.on('close', () => {
-      // eslint-disable-next-line no-console
-      console.log(
-        `Debugger for page ${pageId} and ${this._name} disconnected.`,
-      );
+      debug(`Debugger for page ${pageId} and ${this._name} disconnected.`);
       this._sendMessageToDevice({
         event: 'disconnect',
         payload: {
@@ -153,8 +145,7 @@ class Device {
       const debuggerInfo = this._debuggerConnections.get(pageId);
       const debuggerSocket = debuggerInfo ? debuggerInfo.socket : null;
       if (debuggerSocket && debuggerSocket.readyState == WS.OPEN) {
-        // eslint-disable-next-line no-console
-        console.log(chalk.green(`Page ${pageId} is reloading.`));
+        debug(`Page ${pageId} is reloading.`);
         debuggerSocket.send(JSON.stringify({method: 'reload'}));
       }
     } else if (message.event === 'wrappedEvent') {
@@ -174,8 +165,7 @@ class Device {
       this._processMessageFromDevice(parsedPayload, debuggerInfo);
 
       const messageToSend = JSON.stringify(parsedPayload);
-      // eslint-disable-next-line no-console
-      console.log(chalk.green('-> To debugger: ' + messageToSend));
+      debug('-> To debugger: ' + messageToSend);
       debuggerSocket.send(messageToSend);
     }
   }
@@ -184,8 +174,7 @@ class Device {
   _sendMessageToDevice(message: MessageToDevice) {
     try {
       if (message.event !== 'getPages') {
-        // eslint-disable-next-line no-console
-        console.log(chalk.yellow('-> To device' + JSON.stringify(message)));
+        debug('-> To device' + JSON.stringify(message));
       }
       this._deviceSocket.send(JSON.stringify(message));
     } catch (error) {}

packages/metro-inspector-proxy/src/InspectorProxy.js

@@ -13,6 +13,7 @@
 const Device = require('./Device');
 const WS = require('ws');
 
+const debug = require('debug')('Metro:InspectorProxy');
 const url = require('url');
 
 import type {
@@ -165,13 +166,11 @@ class InspectorProxy {
           new Device(deviceId, deviceName, appName, socket),
         );
 
-        // eslint-disable-next-line no-console
-        console.log(`Got new connection: device=${deviceName}, app=${appName}`);
+        debug(`Got new connection: device=${deviceName}, app=${appName}`);
 
         socket.on('close', () => {
           this._devices.delete(deviceId);
-          // eslint-disable-next-line no-console
-          console.log(`Device ${deviceName} disconnected.`);
+          debug(`Device ${deviceName} disconnected.`);
         });
       } catch (e) {
         console.error('error', e);