Skip to content

Commit 7fead59

Browse files
authored
jest-worker: Avoid crash when "--max-old-space-size" inside process.execArgv (#12097)
1 parent 30a69fb commit 7fead59

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
### Fixes
66

7+
- `[jest-worker]` Filter `execArgv` correctly ([#12097](https://github.com/facebook/jest/pull/12097))
8+
79
### Chore & Maintenance
810

911
### Performance
@@ -27,6 +29,7 @@
2729
- `[jest-environment-jsdom]` Add `@types/jsdom` dependency ([#11999](https://github.com/facebook/jest/pull/11999))
2830
- `[jest-environment-jsdom]` Do not reset the global.document too early on teardown ([#11871](https://github.com/facebook/jest/pull/11871))
2931
- `[jest-transform]` Improve error and warning messages ([#11998](https://github.com/facebook/jest/pull/11998))
32+
- `[jest-worker]` Pass `execArgv` correctly to `worker_threads` worker ([#12069](https://github.com/facebook/jest/pull/12069))
3033

3134
### Chore & Maintenance
3235

packages/jest-worker/src/workers/NodeThreadsWorker.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,10 @@ export default class ExperimentalWorker implements WorkerInterface {
6565
JEST_WORKER_ID: String(this._options.workerId + 1), // 0-indexed workerId, 1-indexed JEST_WORKER_ID
6666
},
6767
eval: false,
68-
execArgv: process.execArgv,
68+
// Suppress --max_old_space_size flags while preserving others (like --harmony). See https://nodejs.org/api/worker_threads.html#new-workerfilename-options
69+
execArgv: process.execArgv.filter(
70+
v => !/^--(max_old_space_size)/.test(v),
71+
),
6972
// @ts-expect-error: added in newer versions
7073
resourceLimits: this._options.resourceLimits,
7174
stderr: true,

0 commit comments

Comments
 (0)