Skip to content

Commit b860241

Browse files
committed
Naming changes
1 parent 8834940 commit b860241

33 files changed

+52
-52
lines changed

packages/react-scripts/fixtures/kitchensink/src/App.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,23 @@ class BuiltEmitter extends React.Component {
88
componentDidMount() {
99
const { feature } = this.props
1010
if (!Component.isPrototypeOf(feature)) {
11-
this.notifyRendered();
11+
this.handleReady();
1212
}
1313
}
1414

15-
notifyRendered() {
15+
handleReady() {
1616
document.dispatchEvent(new Event('ReactFeatureDidMount'));
1717
}
1818

1919
render() {
2020
const {
2121
props: { feature },
22-
notifyRendered
22+
handleReady
2323
} = this;
2424
return (
2525
<div>
2626
{createElement(feature, {
27-
notifyRendered
27+
onReady: handleReady
2828
})}
2929
</div>
3030
);

packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import load from 'absoluteLoad'
33

44
export default class extends Component {
55
static propTypes = {
6-
notifyRendered: PropTypes.func.isRequired
6+
onReady: PropTypes.func.isRequired
77
}
88

99
constructor(props) {
@@ -17,7 +17,7 @@ export default class extends Component {
1717
}
1818

1919
componentDidUpdate() {
20-
this.props.notifyRendered();
20+
this.props.onReady();
2121
}
2222

2323
render() {

packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('NODE_PATH', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<NodePath notifyRendered={resolve} />, div);
9+
ReactDOM.render(<NodePath onReady={resolve} />, div);
1010
});
1111
});
1212
});

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('array destructuring', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<ArrayDestructuring notifyRendered={resolve} />, div);
9+
ReactDOM.render(<ArrayDestructuring onReady={resolve} />, div);
1010
});
1111
});
1212
});

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function load(users) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('array spread', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<ArraySpread notifyRendered={resolve} />, div);
9+
ReactDOM.render(<ArraySpread onReady={resolve} />, div);
1010
});
1111
});
1212
});

packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ async function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func.isRequired
14+
onReady: PropTypes.func.isRequired
1515
}
1616

1717
constructor(props) {
@@ -25,7 +25,7 @@ export default class extends Component {
2525
}
2626

2727
componentDidUpdate() {
28-
this.props.notifyRendered();
28+
this.props.onReady();
2929
}
3030

3131
render() {

packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ describe('async/await', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
88
return new Promise(resolve => {
9-
ReactDOM.render(<AsyncAwait notifyRendered={resolve} />, div);
9+
ReactDOM.render(<AsyncAwait onReady={resolve} />, div);
1010
});
1111
});
1212
});

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React, { Component, PropTypes } from 'react'
22

33
export default class extends Component {
44
static propTypes = {
5-
notifyRendered: PropTypes.func.isRequired
5+
onReady: PropTypes.func.isRequired
66
}
77

88
users = [
@@ -13,7 +13,7 @@ export default class extends Component {
1313
];
1414

1515
componentDidMount() {
16-
this.props.notifyRendered()
16+
this.props.onReady()
1717
}
1818

1919
render() {

0 commit comments

Comments
 (0)