test: Added CrudDispatcher integration test

Author: manusa

src/main/java/io/fabric8/mockwebserver/crud/CrudDispatcher.java

@@ -23,8 +23,9 @@
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.RecordedRequest;
 
+import java.net.HttpURLConnection;
 import java.util.ArrayList;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -36,7 +37,7 @@ public class CrudDispatcher extends Dispatcher {
     private static final String GET = "GET";
     private static final String DELETE = "DELETE";
 
-    protected final Map<AttributeSet, String> map = new HashMap<>();
+    protected final Map<AttributeSet, String> map = new LinkedHashMap<>();
 
     protected final Context context;
     protected final AttributeExtractor attributeExtractor;
@@ -51,9 +52,7 @@ public CrudDispatcher(Context context, AttributeExtractor attributeExtractor, Re
     @Override
     public MockResponse dispatch(RecordedRequest request) {
         String path = request.getPath();
-        String method = request.getMethod();
-
-        switch (method.toUpperCase()) {
+        switch (request.getMethod().toUpperCase()) {
             case POST:
                 return handleCreate(path, request.getBody().readUtf8());
             case PUT:
@@ -124,7 +123,12 @@ public MockResponse handlePatch(String path, String body) {
      * @return a MockResponse to be dispatched.
      */
     public MockResponse handleUpdate(String path, String body) {
-        return handleCreate(path, body);
+        final String currentItem = doGet(path);
+        final MockResponse response = handleCreate(path, body);
+        if (currentItem == null) {
+            response.setResponseCode(HttpURLConnection.HTTP_CREATED);
+        }
+        return response;
     }
 
     /**

src/test/groovy/io/fabric8/mockwebserver/DefaultMockServerCrudTest.groovy

@@ -0,0 +1,142 @@
+/**
+ * Copyright (C) 2015 Red Hat, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.fabric8.mockwebserver
+
+import com.fasterxml.jackson.databind.ObjectMapper
+import io.fabric8.mockwebserver.crud.CrudDispatcher
+import okhttp3.MediaType
+import okhttp3.OkHttpClient
+import okhttp3.Request
+import okhttp3.RequestBody
+import okhttp3.mockwebserver.MockWebServer
+import spock.lang.Shared
+import spock.lang.Specification
+
+class DefaultMockServerCrudTest extends Specification {
+
+  DefaultMockServer server
+
+  @Shared
+  def client = new OkHttpClient()
+
+  @Shared
+  def mapper = new ObjectMapper()
+
+  def setup() {
+    server = new DefaultMockServer(new Context(), new MockWebServer(), new HashMap<>(),
+        new CrudDispatcher(new Context(), new UserAttributeExtractor(), new JsonResponseComposer()), false)
+    server.start()
+  }
+
+  def cleanup() {
+    server.shutdown()
+  }
+
+  def "get /, with empty store, should return 404"() {
+    when:
+    def result = client.newCall(new Request.Builder().url(server.url("/")).build()).execute()
+
+    then:
+    assert result.code() == 404
+    assert result.body().string() == ""
+  }
+
+  def "get /, with one item, should return item"() {
+    given:
+    client.newCall(new Request.Builder().url(server.url("/")).post(
+        RequestBody.create(MediaType.parse("application/json"),
+            mapper.writeValueAsString(new User(1L, "user", true)))).build()).
+        execute()
+
+    when:
+    def result = client.newCall(new Request.Builder().url(server.url("/")).build()).execute()
+
+    then:
+    assert result.code() == 200
+    assert result.body().string() == "{\"id\":1,\"username\":\"user\",\"enabled\":true}"
+  }
+
+  def "get /, with multiple items, should return array"() {
+    given:
+    client.newCall(new Request.Builder().url(server.url("/")).post(
+        RequestBody.create(MediaType.parse("application/json"),
+            mapper.writeValueAsString(new User(1L, "user", true)))).build()).
+        execute()
+    client.newCall(new Request.Builder().url(server.url("/")).post(
+        RequestBody.create(MediaType.parse("application/json"),
+            mapper.writeValueAsString(new User(2L, "user-2", true)))).build()).
+        execute()
+
+    when:
+    def result = client.newCall(new Request.Builder().url(server.url("/")).build()).execute()
+
+    then:
+    assert result.code() == 200
+    assert result.body().string() ==
+        "[{\"id\":1,\"username\":\"user\",\"enabled\":true},{\"id\":2,\"username\":\"user-2\",\"enabled\":true}]"
+  }
+
+  def "get /1, with existent item, should return item"() {
+    given:
+    client.newCall(new Request.Builder().url(server.url("/")).post(
+        RequestBody.create(MediaType.parse("application/json"),
+            mapper.writeValueAsString(new User(1L, "user", true)))).build()).
+        execute()
+    client.newCall(new Request.Builder().url(server.url("/")).post(
+        RequestBody.create(MediaType.parse("application/json"),
+            mapper.writeValueAsString(new User(2L, "user-2", true)))).build()).
+        execute()
+
+    when:
+    def result = client.newCall(new Request.Builder().url(server.url("/1")).build()).execute()
+
+    then:
+    assert result.code() == 200
+    assert result.body().string() == "{\"id\":1,\"username\":\"user\",\"enabled\":true}"
+  }
+
+  def "put /1, with missing item, should create item"() {
+    when:
+    def result = client.newCall(new Request.Builder().url(server.url("/1")).put(
+        RequestBody.create(MediaType.parse("application/json"),
+            mapper.writeValueAsString(new User(1L, "user-replaced", true)))).build()).
+        execute()
+
+    then:
+    assert result.code() == 201
+    assert result.body().string() == "{\"id\":1,\"username\":\"user-replaced\",\"enabled\":true}"
+  }
+
+  def "put /1, with existent item, should replace item"() {
+    given:
+    client.newCall(new Request.Builder().url(server.url("/")).post(
+        RequestBody.create(MediaType.parse("application/json"),
+            mapper.writeValueAsString(new User(1L, "user", true)))).build()).
+        execute()
+
+    when:
+    def result = client.newCall(new Request.Builder().url(server.url("/1")).put(
+        RequestBody.create(MediaType.parse("application/json"),
+            mapper.writeValueAsString(new User(1L, "user-replaced", true)))).build()).
+        execute()
+
+    then:
+    assert result.code() == 202
+    assert result.body().string() == "{\"id\":1,\"username\":\"user-replaced\",\"enabled\":true}"
+    def item = client.newCall(new Request.Builder().url(server.url("/1")).build()).execute()
+    assert item.body().string() == "{\"id\":1,\"username\":\"user-replaced\",\"enabled\":true}"
+  }
+}

src/test/groovy/io/fabric8/mockwebserver/JsonResponseComposer.groovy

@@ -0,0 +1,27 @@
+/**
+ * Copyright (C) 2015 Red Hat, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.fabric8.mockwebserver
+
+import io.fabric8.mockwebserver.crud.ResponseComposer
+
+import java.util.stream.Collectors
+
+class JsonResponseComposer implements ResponseComposer {
+  @Override
+  String compose(Collection<String> items) {
+    return "[" + items.stream().collect(Collectors.joining(",")) + "]"
+  }
+}

src/test/groovy/io/fabric8/mockwebserver/UserAttributeExtractor.groovy

@@ -0,0 +1,40 @@
+/**
+ * Copyright (C) 2015 Red Hat, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.fabric8.mockwebserver
+
+import com.fasterxml.jackson.databind.ObjectMapper
+import io.fabric8.mockwebserver.crud.Attribute
+import io.fabric8.mockwebserver.crud.AttributeExtractor
+import io.fabric8.mockwebserver.crud.AttributeSet
+
+class UserAttributeExtractor implements AttributeExtractor {
+
+  static def mapper = new ObjectMapper()
+
+  @Override
+  AttributeSet fromPath(String path) {
+    if (path.trim().isBlank() || path.trim() == "/") {
+      return new AttributeSet();
+    }
+    return new AttributeSet(new Attribute("id", path.substring(1)))
+  }
+
+  @Override
+  AttributeSet fromResource(String resource) {
+    def user = mapper.readValue(resource, User)
+    return new AttributeSet(new Attribute("id", user.getId().toString()))
+  }
+}