docs: New Readme #10
Merged
docs: New Readme #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmd-azeez
approved these changes
Oct 10, 2023
Comment on lines
+56
to
+107
| // @Test | ||
| // public void shouldInvokeFunctionFromUrlWasmSourceHostFuncs() { | ||
| // var url = "https://github.com/extism/plugins/releases/latest/download/count_vowels_kvstore.wasm"; | ||
| // var manifest = new Manifest(List.of(UrlWasmSource.fromUrl(url))); | ||
| // | ||
| // // Our application KV store | ||
| // // Pretend this is redis or a database :) | ||
| // var kvStore = new HashMap<String, byte[]>(); | ||
| // | ||
| // ExtismFunction kvWrite = (plugin, params, returns, data) -> { | ||
| // System.out.println("Hello from Java Host Function!"); | ||
| // var key = plugin.inputString(params[0]); | ||
| // var value = plugin.inputBytes(params[1]); | ||
| // System.out.println("Writing to key " + key); | ||
| // kvStore.put(key, value); | ||
| // }; | ||
| // | ||
| // ExtismFunction kvRead = (plugin, params, returns, data) -> { | ||
| // System.out.println("Hello from Java Host Function!"); | ||
| // var key = plugin.inputString(params[0]); | ||
| // System.out.println("Reading from key " + key); | ||
| // var value = kvStore.get(key); | ||
| // if (value == null) { | ||
| // // default to zeroed bytes | ||
| // var zero = new byte[]{0,0,0,0}; | ||
| // plugin.returnBytes(returns[0], zero); | ||
| // } else { | ||
| // plugin.returnBytes(returns[0], value); | ||
| // } | ||
| // }; | ||
| // | ||
| // HostFunction kvWriteHostFn = new HostFunction<>( | ||
| // "kv_write", | ||
| // new LibExtism.ExtismValType[]{LibExtism.ExtismValType.I64, LibExtism.ExtismValType.I64}, | ||
| // new LibExtism.ExtismValType[0], | ||
| // kvWrite, | ||
| // Optional.empty() | ||
| // ); | ||
| // | ||
| // HostFunction kvReadHostFn = new HostFunction<>( | ||
| // "kv_read", | ||
| // new LibExtism.ExtismValType[]{LibExtism.ExtismValType.I64}, | ||
| // new LibExtism.ExtismValType[]{LibExtism.ExtismValType.I64}, | ||
| // kvRead, | ||
| // Optional.empty() | ||
| // ); | ||
| // | ||
| // HostFunction[] functions = {kvWriteHostFn, kvReadHostFn}; | ||
| // var plugin = new Plugin(manifest, false, functions); | ||
| // var output = plugin.call("count_vowels", "Hello, World!"); | ||
| // } | ||
|
|
There was a problem hiding this comment.
Beside this commented out test case, the readme lgtm. Do we remove the test or keep it in?
There was a problem hiding this comment.
It's broken, so i'm going to file a separate ticket and follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5