Use slices.Equal() to compare slices

Author: IsaacG

exercises/concept/parsing-log-files/parsing_log_files_test.go

@@ -1,6 +1,9 @@
 package parsinglogfiles
 
-import "testing"
+import (
+	"slices"
+	"testing"
+)
 
 func TestIsValidLine(t *testing.T) {
 	tests := []struct {
@@ -91,7 +94,7 @@ func TestSplitLogLine(t *testing.T) {
 		t.Run(tt.description, func(t *testing.T) {
 			got := SplitLogLine(tt.text)
 			want := tt.expected
-			if !stringSliceEqual(want, got) {
+			if !slices.Equal(want, got) {
 				t.Fatalf("expected: %v, got: %v", want, got)
 			}
 		})
@@ -183,7 +186,7 @@ func TestTagWithUserName(t *testing.T) {
 		t.Run(tt.description, func(t *testing.T) {
 			got := TagWithUserName(tt.lines)
 			want := tt.expected
-			if !stringSliceEqual(want, got) {
+			if !slices.Equal(want, got) {
 				for i := range got {
 					if want[i] != got[i] {
 						t.Fatalf("expected: %v, got: %v", want[i], got[i])
@@ -194,18 +197,3 @@ func TestTagWithUserName(t *testing.T) {
 		})
 	}
 }
-
-func stringSliceEqual(a, b []string) bool {
-	if len(a) != len(b) {
-		return false
-	}
-	if len(a) == 0 {
-		return true
-	}
-	for i := range a {
-		if a[i] != b[i] {
-			return false
-		}
-	}
-	return true
-}

exercises/practice/pov/pov_test.go

@@ -1,6 +1,7 @@
 package pov
 
 import (
+	"slices"
 	"sort"
 	"testing"
 )
@@ -238,7 +239,7 @@ func TestPathTo(t *testing.T) {
 		t.Run(tt.description, func(t *testing.T) {
 			got := tt.tree.PathTo(tt.from, tt.to)
 			want := tt.expected
-			if !stringSliceEqual(want, got) {
+			if !slices.Equal(want, got) {
 				t.Fatalf("expected: %v, got: %v", want, got)
 			}
 		})
@@ -317,18 +318,3 @@ func treeSliceEqual(trs1, trs2 []*Tree) bool {
 	}
 	return true
 }
-
-func stringSliceEqual(a, b []string) bool {
-	if len(a) != len(b) {
-		return false
-	}
-	if len(a) == 0 {
-		return true
-	}
-	for i := 0; i < len(a); i++ {
-		if a[i] != b[i] {
-			return false
-		}
-	}
-	return true
-}

exercises/practice/tree-building/tree_building_test.go

@@ -4,6 +4,7 @@ package tree
 import (
 	"fmt"
 	"math/rand"
+	"slices"
 	"testing"
 )
 
@@ -365,21 +366,6 @@ func nodeEqual(node1, node2 *Node) bool {
 	case node1 != nil && node2 == nil:
 		return false
 	default:
-		return node1.ID == node2.ID && nodeSliceEqual(node1.Children, node2.Children)
+		return node1.ID == node2.ID && slices.EqualFunc(node1.Children, node2.Children, nodeEqual)
 	}
 }
-
-func nodeSliceEqual(nodes1, nodes2 []*Node) bool {
-	if len(nodes1) == 0 && len(nodes2) == 0 {
-		return true
-	}
-	if len(nodes1) != len(nodes2) {
-		return false
-	}
-	for i := range nodes1 {
-		if !nodeEqual(nodes1[i], nodes2[i]) {
-			return false
-		}
-	}
-	return true
-}