Skip to content

Commit 7911b0d

Browse files
committed
Merge pull request #282 from exercism/rm-submit-postmsg
Remove random encouragement after submitting
2 parents 8cb8ef1 + 5353057 commit 7911b0d

1 file changed

Lines changed: 1 addition & 36 deletions

File tree

cmd/submit.go

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@ package cmd
33
import (
44
"fmt"
55
"log"
6-
"math/rand"
76
"os"
87
"path/filepath"
9-
"time"
108

119
"github.com/codegangsta/cli"
1210
"github.com/exercism/cli/api"
@@ -96,38 +94,5 @@ func Submit(ctx *cli.Context) {
9694
log.Fatal(err)
9795
}
9896

99-
msg := `
100-
Submitted %s in %s.
101-
Your submission can be found online at %s
102-
`
103-
104-
if submission.Iteration == 1 {
105-
msg += `
106-
To get the next exercise, run "exercism fetch" again.
107-
`
108-
rand.Seed(time.Now().UTC().UnixNano())
109-
phrases := []string{
110-
"For bonus points",
111-
"Don't stop now: The fun's just begun",
112-
"Some tips to continue",
113-
}
114-
msg += fmt.Sprintf("\n## %s\n", phrases[rand.Intn(len(phrases))])
115-
msg += tips
116-
}
117-
118-
fmt.Printf(msg, submission.Name, submission.Language, submission.URL)
97+
fmt.Printf("%s - %s\n%s\n\n", submission.Language, submission.Name, submission.URL)
11998
}
120-
121-
const tips = `
122-
Did you get the tests passing and the code clean? If you want to, these are some
123-
additional things you could try:
124-
125-
* Remove as much duplication as you possibly can.
126-
* Optimize for readability, even if it means introducing duplication.
127-
* If you've removed all the duplication, do you have a lot of conditionals? Try
128-
finding ways to reduce or remove them. How does this affect your code's
129-
readability? Its performance?
130-
131-
Then please share your thoughts in a comment on the submission. Did this
132-
experiment make the code better? Worse? Did you learn anything from it?
133-
`

0 commit comments

Comments
 (0)