add specific test for URL encoded filenames

Author: nywilken

cmd/download_test.go

@@ -162,10 +162,14 @@ func fakeDownloadServer(requestor, teamSlug string) *httptest.Server {
 		fmt.Fprint(w, "this is file 1")
 	})
 
-	mux.HandleFunc("/subdir/file-2#.txt", func(w http.ResponseWriter, r *http.Request) {
+	mux.HandleFunc("/subdir/file-2.txt", func(w http.ResponseWriter, r *http.Request) {
 		fmt.Fprint(w, "this is file 2")
 	})
 
+	mux.HandleFunc("/special-char-filename#.txt", func(w http.ResponseWriter, r *http.Request) {
+		fmt.Fprint(w, "this is a special file")
+	})
+
 	mux.HandleFunc("/file-3.txt", func(w http.ResponseWriter, r *http.Request) {
 		fmt.Fprint(w, "")
 	})
@@ -199,9 +203,14 @@ func assertDownloadedCorrectFiles(t *testing.T, targetDir string) {
 		},
 		{
 			desc:     "a file in a subdirectory",
-			path:     filepath.Join(targetDir, "bogus-track", "bogus-exercise", "subdir", "file-2#.txt"),
+			path:     filepath.Join(targetDir, "bogus-track", "bogus-exercise", "subdir", "file-2.txt"),
 			contents: "this is file 2",
 		},
+		{
+			desc:     "a file that requires URL encoding",
+			path:     filepath.Join(targetDir, "bogus-track", "bogus-exercise", "special-char-filename#.txt"),
+			contents: "this is a special file",
+		},
 	}
 
 	for _, file := range expectedFiles {
@@ -238,7 +247,8 @@ const payloadTemplate = `
 		"file_download_base_url": "%s",
 		"files": [
 			"/file-1.txt",
-			"/subdir/file-2#.txt",
+			"/subdir/file-2.txt",
+			"/special-char-filename#.txt",
 			"/file-3.txt"
 		],
 		"iteration": {