Skip to content

Commit 60207ea

Browse files
authored
Update minimum supported Go version to 1.9 (#635)
This change drops support for Go1.8 and sets the minimum to Go1.9. By making this change we are able to use the same testing steps on *nix and Windows. Travis and Appveyor build scripts have been updated to reflect the said testing step.
1 parent 78bdc08 commit 60207ea

3 files changed

Lines changed: 9 additions & 17 deletions

File tree

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ language: go
33
sudo: false
44

55
go:
6-
- 1.8
7-
- 1.9
6+
- "1.9"
7+
- "1.10.x"
88
- tip
99

1010
install:
1111
- go get -u github.com/golang/dep/...
1212
- dep ensure
1313

1414
script:
15-
- go test $(go list ./... | grep -v /vendor/)
15+
- go test -cover ./...

CONTRIBUTING.md

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Exercism would be impossible without people like you being willing to spend time
55

66
## Dependencies
77

8-
You'll need Go version 1.8 or higher. Follow the directions on http://golang.org/doc/install
8+
You'll need Go version 1.9 or higher. Follow the directions on http://golang.org/doc/install
99

1010
You will also need `dep`, the Go dependency management tool. Follow the directions on https://golang.github.io/dep/docs/installation.html
1111

@@ -19,7 +19,7 @@ If you don't care how and why and just want something that works, follow these s
1919

2020
1. [fork this repo on the GitHub webpage][fork]
2121
1. `go get github.com/exercism/cli/exercism`
22-
1. `cd $GOPATH/src/github.com/exercism/cli` (or `cd %GOPATH%/src/github.com/exercism/cli` on Windows)
22+
1. `cd $GOPATH/src/github.com/exercism/cli` (or `cd %GOPATH%\src\github.com\exercism\cli` on Windows)
2323
1. `git remote rename origin upstream`
2424
1. `git remote add origin git@github.com:<your-github-username>/cli.git`
2525
1. `git checkout -b development`
@@ -35,20 +35,12 @@ If you care about the details, check out the blog post [Contributing to Open Sou
3535

3636
## Running the Tests
3737

38-
To run the tests locally on Linux or MacOS, use
38+
To run the tests locally
3939

4040
```
41-
go test $(go list ./... | grep -v vendor)
41+
go test ./...
4242
```
4343

44-
On Windows, the command is more painful (sorry!):
45-
46-
```
47-
for /f "" %G in ('go list ./... ^| find /i /v "/vendor/"') do @go test %G
48-
```
49-
50-
As of Go 1.9 this is simplified to `go test ./...`.
51-
5244
## Manual Testing against Exercism
5345

5446
To test your changes while doing everyday Exercism work you
@@ -66,7 +58,7 @@ On Windows:
6658

6759
- `cd /d %GOPATH%\src\github.com\exercism\cli`
6860
- `go build -o testercism.exe exercism\main.go`
69-
- `testercism.exe —help`
61+
- `testercism.exe —h`
7062

7163
### Building for All Platforms
7264

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ install:
1818
- c:\gopath\bin\dep.exe ensure
1919

2020
build_script:
21-
- for /f "" %%G in ('go list github.com/exercism/cli/... ^| find /i /v "/vendor/"') do ( go test %%G & IF ERRORLEVEL == 1 EXIT 1)
21+
- go test -cover ./...

0 commit comments

Comments
 (0)