Improve the API ping in configure command

This distinguishes between an error in the HTTP request (e.g.
no service at URL), and an error returned from the API (e.g. 500 error).

Author: Katrina Owen

api/client.go

@@ -87,15 +87,18 @@ func (c *Client) TokenIsValid() (bool, error) {
 }
 
 // IsPingable calls the API /ping to determine whether the API can be reached.
-func (c *Client) IsPingable() (bool, error) {
+func (c *Client) IsPingable() error {
 	url := fmt.Sprintf("%s/ping", c.APIBaseURL)
 	req, err := c.NewRequest("GET", url, nil)
 	if err != nil {
-		return false, err
+		return err
 	}
 	resp, err := c.Do(req)
 	if err != nil {
-		return false, err
+		return err
 	}
-	return resp.StatusCode == http.StatusOK, nil
+	if resp.StatusCode != http.StatusOK {
+		return fmt.Errorf("API returned %s", resp.Status)
+	}
+	return nil
 }

cmd/configure.go

@@ -91,8 +91,7 @@ func runConfigure(configuration config.Configuration, flags *pflag.FlagSet) erro
 			return err
 		}
 
-		ok, err := client.IsPingable()
-		if !ok || err != nil {
+		if err := client.IsPingable(); err != nil {
 			return fmt.Errorf("The base API URL '%s' cannot be reached.\n\n%s", baseURL, err)
 		}
 	}