Use api error helper

Author: jdsutherland

cmd/submit.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"io"
 	"mime/multipart"
-	"net/http"
 	"os"
 	"path/filepath"
 
@@ -268,12 +267,8 @@ func (s *submitCmdContext) submit(metadata *workspace.ExerciseMetadata, docs []w
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode == http.StatusBadRequest {
-		return decodedAPIError(resp)
-	}
-
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
-		return fmt.Errorf("submission unsuccessful (%s)", resp.Status)
+		return decodedAPIError(resp)
 	}
 
 	bb := &bytes.Buffer{}

cmd/submit_test.go

@@ -611,7 +611,7 @@ func TestSubmitServerErr(t *testing.T) {
 	assert.Regexp(t, "test error", err.Error())
 }
 
-func TestHandle404Response(t *testing.T) {
+func TestHandleErrorResponse(t *testing.T) {
 	handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(404)
 	})
@@ -646,10 +646,9 @@ func TestHandle404Response(t *testing.T) {
 	}
 
 	err = runSubmit(cfg, pflag.NewFlagSet("fake", pflag.PanicOnError), files)
-	if assert.Error(t, err) {
-		assert.Contains(t, err.Error(), "unsuccessful")
-	}
+	assert.Error(t, err)
 }
+
 func TestSubmissionNotConnectedToRequesterAccount(t *testing.T) {
 	submittedFiles := map[string]string{}
 	ts := fakeSubmitServer(t, submittedFiles)