Skip to content

Commit a324b8d

Browse files
greggdonovanclaude
andcommitted
Add plugin test coverage to CI and BCR presubmit
- Add grafana_with_plugins_docker_test to Linux CI - Add plugin build and test to BCR presubmit - Update release.yml comment (BCR app is now installed) - Clarify extensions.bzl comment about macOS OCI builds 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 0e84b7f commit a324b8d

File tree

4 files changed

+16
-5
lines changed

4 files changed

+16
-5
lines changed

.bcr/presubmit.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,9 @@ bcr_test_module_linux:
3030
build_targets:
3131
- "//example:grafana"
3232
- "//test:grafana"
33+
- "//test:grafana_with_plugins"
34+
test_oci:
35+
name: "Test OCI targets (Linux only)"
36+
test_targets:
37+
- "//test:grafana_docker_test"
38+
- "//test:grafana_with_plugins_docker_test"

.github/workflows/ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ jobs:
3333
env:
3434
USE_BAZEL_VERSION: ${{ matrix.bazel }}
3535

36+
- name: Test Docker targets
37+
run: bazel test //test:grafana_docker_test //test:grafana_with_plugins_docker_test
38+
env:
39+
USE_BAZEL_VERSION: ${{ matrix.bazel }}
40+
3641
build-macos:
3742
runs-on: macos-latest
3843
strategy:

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ jobs:
2626
rules_grafana-*.tar.gz
2727
rules_grafana-*.tar.gz.sha256
2828
generate_release_notes: true
29-
# The Publish to BCR GitHub App (if installed) will automatically
30-
# detect this release and create a PR to the BCR
29+
# The Publish to BCR GitHub App will automatically detect this
30+
# release and create a PR to the BCR

grafana/extensions.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ _grafana_plugin_tag = tag_class(
2828
def _grafana_extension_impl(module_ctx):
2929
"""Implementation for grafana module extension."""
3030

31-
# Pull default grafana container
32-
# Note: Only linux/amd64 is supported. On macOS, Docker Desktop handles
33-
# architecture translation via Rosetta. For CI, OCI builds are skipped on macOS.
31+
# Pull default grafana container (linux/amd64 only).
32+
# OCI image builds are skipped on macOS CI since rules_oci requires a matching
33+
# host platform. For local macOS development, Docker Desktop emulates x86_64.
3434
oci_pull(
3535
name = "grafana_oci",
3636
image = "index.docker.io/grafana/grafana",

0 commit comments

Comments
 (0)