Skip to content

Commit f4ac548

Browse files
authored
ethdb/pebble: cap memory table size as maxMemTableSize-1 (#28444)
1 parent 285202a commit f4ac548

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

ethdb/pebble/pebble.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,15 @@ func New(file string, cache int, handles int, namespace string, readonly bool, e
160160
// including a frozen memory table and another live one.
161161
memTableLimit := 2
162162
memTableSize := cache * 1024 * 1024 / 2 / memTableLimit
163-
if memTableSize > maxMemTableSize {
164-
memTableSize = maxMemTableSize
163+
164+
// The memory table size is currently capped at maxMemTableSize-1 due to a
165+
// known bug in the pebble where maxMemTableSize is not recognized as a
166+
// valid size.
167+
//
168+
// TODO use the maxMemTableSize as the maximum table size once the issue
169+
// in pebble is fixed.
170+
if memTableSize >= maxMemTableSize {
171+
memTableSize = maxMemTableSize - 1
165172
}
166173
db := &Database{
167174
fn: file,

0 commit comments

Comments
 (0)