From 4daebb96bfa0e5c90d3e1e6b320dd07d3f8e6d58 Mon Sep 17 00:00:00 2001 From: danceratopz Date: Thu, 5 Dec 2024 09:30:10 +0100 Subject: [PATCH 1/3] chore(ci): remove checkout submodule init for eest EEST doesn't have any submodules. --- .github/workflows/tox_verify.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tox_verify.yaml b/.github/workflows/tox_verify.yaml index b534eae85fc..dde79a5d4dd 100644 --- a/.github/workflows/tox_verify.yaml +++ b/.github/workflows/tox_verify.yaml @@ -32,9 +32,8 @@ jobs: evm-type: "stable" tox-cmd: "uvx --with=tox-uv tox" # run-parallel --parallel-no-spinner" steps: - - uses: actions/checkout@v4 - with: - submodules: true + - name: Checkout ethereum/execution-spec-tests + uses: actions/checkout@v4 - uses: ./.github/actions/build-evm-base id: evm-builder with: From 759367c059236b59ffa29d89d009750c8b2c4db7 Mon Sep 17 00:00:00 2001 From: danceratopz Date: Thu, 5 Dec 2024 10:49:49 +0100 Subject: [PATCH 2/3] chore(ci): use a local eels checkout for framework tests --- .github/configs/eels_resolutions.json | 36 +++++++++++++++++++++++++++ .github/workflows/tox_verify.yaml | 11 ++++++++ tox.ini | 4 +++ 3 files changed, 51 insertions(+) create mode 100644 .github/configs/eels_resolutions.json diff --git a/.github/configs/eels_resolutions.json b/.github/configs/eels_resolutions.json new file mode 100644 index 00000000000..bc7a8c88bb8 --- /dev/null +++ b/.github/configs/eels_resolutions.json @@ -0,0 +1,36 @@ +{ + "EELSMaster": { + "git_url": "https://github.com/ethereum/execution-specs.git", + "branch": "master" + }, + "Frontier": { + "path": "../../execution-specs/src/ethereum/frontier" + }, + "Homestead": { + "path": "../../execution-specs/src/ethereum/homestead" + }, + "Byzantium": { + "path": "../../execution-specs/src/ethereum/byzantium" + }, + "ConstantinopleFix": { + "path": "../../execution-specs/src/ethereum/constantinople" + }, + "Istanbul": { + "path": "../../execution-specs/src/ethereum/istanbul" + }, + "Berlin": { + "path": "../../execution-specs/src/ethereum/berlin" + }, + "London": { + "path": "../../execution-specs/src/ethereum/london" + }, + "Paris": { + "path": "../../execution-specs/src/ethereum/paris" + }, + "Shanghai": { + "path": "../../execution-specs/src/ethereum/shanghai" + }, + "Cancun": { + "path": "../../execution-specs/src/ethereum/cancun" + } +} diff --git a/.github/workflows/tox_verify.yaml b/.github/workflows/tox_verify.yaml index dde79a5d4dd..f2591d45dbf 100644 --- a/.github/workflows/tox_verify.yaml +++ b/.github/workflows/tox_verify.yaml @@ -34,6 +34,15 @@ jobs: steps: - name: Checkout ethereum/execution-spec-tests uses: actions/checkout@v4 + - name: Checkout ethereum/execution-specs + uses: actions/checkout@v4 + with: + repository: ethereum/execution-specs + ref: 9b95554a88d2a8485f8180254d0f6a493a593fda + path: execution-specs + sparse-checkout: | + src/ethereum + fetch-depth: 1 - uses: ./.github/actions/build-evm-base id: evm-builder with: @@ -53,6 +62,8 @@ jobs: # Add additional packages on 3.11: https://github.com/ethereum/execution-spec-tests/issues/274 if [ ${{ matrix.python }} == '3.11' ]; then brew install autoconf automake libtool; fi - name: Run Tox (CPython) + env: + EELS_RESOLUTIONS_FILE: ${{ github.workspace }}/.github/configs/eels_resolutions.json run: ${{ matrix.tox-cmd }} - uses: DavidAnson/markdownlint-cli2-action@v16 with: diff --git a/tox.ini b/tox.ini index 2260cb68bb9..40656326a27 100644 --- a/tox.ini +++ b/tox.ini @@ -16,6 +16,10 @@ wheel_build_env = .pkg [testenv:framework] description = Run checks on helper libraries and test framework +setenv = + # Only use EELS_RESOLUTIONS_FILE if it is set in the environment (eg, in CI) + EELS_RESOLUTIONS_FILE = {env:EELS_RESOLUTIONS_FILE:} + extras = test lint From 8b6dcee00d568c2c169a25ddd405db908942e13e Mon Sep 17 00:00:00 2001 From: danceratopz Date: Thu, 5 Dec 2024 11:03:04 +0100 Subject: [PATCH 3/3] docs: update changelog --- docs/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 37b2cd513c2..d6266879f50 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -75,6 +75,7 @@ Test fixtures for use by clients are available for each release on the [Github r - 🔀 Move pytest plugin `pytest_plugins.filler.solc` to `pytest_plugins.solc.solc` ([#823](https://github.com/ethereum/execution-spec-tests/pull/823)). - 🐞 Asserts that the deploy docs tags workflow is only triggered for full releases ([#857](https://github.com/ethereum/execution-spec-tests/pull/857)). - ✨ A new application-wide configuration manager provides access to environment and application configurations. ([#892](https://github.com/ethereum/execution-spec-tests/pull/892)). +- 🐞 Use a local version of ethereum/execution-specs (EELS) when running the framework tests in CI ([#997](https://github.com/ethereum/execution-spec-tests/pull/997)). ### 💥 Breaking Change