This repository was archived by the owner on Oct 18, 2023. It is now read-only.
fix: provide file path to dynamic import transform#33
Merged
privatenumber merged 4 commits intoesbuild-kit:nextfrom Sep 30, 2022
Merged
fix: provide file path to dynamic import transform#33privatenumber merged 4 commits intoesbuild-kit:nextfrom
privatenumber merged 4 commits intoesbuild-kit:nextfrom
Conversation
privatenumber
changed the title
Member
|
This is a breaking change. Will batch with some other changes. |
privatenumber
added a commit
that referenced
this pull request
Sep 30, 2022
BREAKING CHANGE: transformDynamicImport now requires file path Co-authored-by: Hiroki Osame <hiroki.osame@gmail.com>
privatenumber
added a commit
that referenced
this pull request
Oct 2, 2022
BREAKING CHANGE: transformDynamicImport now requires file path Co-authored-by: Hiroki Osame <hiroki.osame@gmail.com>
privatenumber
added a commit
that referenced
this pull request
Oct 4, 2022
BREAKING CHANGE: transformDynamicImport now requires file path Co-authored-by: Hiroki Osame <hiroki.osame@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #32.
Doesn't completely fix the mentioned bug, but looks to be a valid check.