Skip to content
This repository was archived by the owner on Oct 18, 2023. It is now read-only.

Commit 4687e8a

Browse files
fix: keep names in esbuild minification (#26)
1 parent ac726c2 commit 4687e8a

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

src/transform/get-esbuild-options.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ export const getEsbuildOptions = (
2323
* Disabled until esbuild supports names in source maps:
2424
* https://github.com/evanw/esbuild/issues/1296
2525
*/
26-
// minify: true, keepNames: true,
26+
// minify: true,
27+
keepNames: true,
2728
minifySyntax: true,
2829
minifyWhitespace: true,
2930

tests/specs/transform.ts

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@ const fixtures = {
99
ts: `
1010
export default 'default value' as string;
1111
export const named: string = 'named';
12+
export const functionName: string = (function named() {}).name;
1213
`,
1314

1415
esm: `
1516
export default 'default value';
1617
export const named = 'named';
18+
export const functionName = (function named() {}).name;
1719
`,
1820
};
1921

@@ -33,9 +35,11 @@ export default testSuite(({ describe }) => {
3335
'/file.js': transformed.code,
3436
}));
3537

36-
expect(JSON.stringify(fsRequire('/file.js'))).toBe(
37-
'{"default":"default value","named":"named"}',
38-
);
38+
expect(fsRequire('/file.js')).toStrictEqual({
39+
default: 'default value',
40+
functionName: 'named',
41+
named: 'named',
42+
});
3943
});
4044

4145
test('transforms file with inline sourcemap string', () => {
@@ -83,7 +87,11 @@ export default testSuite(({ describe }) => {
8387
);
8488

8589
const imported = await import(base64Module(transformed.code));
86-
expect(JSON.stringify(imported)).toMatch('{"default":"default value","named":"named"}');
90+
expect({ ...imported }).toStrictEqual({
91+
default: 'default value',
92+
functionName: 'named',
93+
named: 'named',
94+
});
8795
});
8896

8997
test('sourcemap file', async () => {

0 commit comments

Comments
 (0)