Merge pull request #2295 from slingamn/shivaram_pushreject

slingamn · web-flow · commit efc1627d2353 · 2025-10-26T00:58:52.000-04:00
fix validation of web push URLs
diff --git a/irc/handlers.go b/irc/handlers.go
@@ -3934,6 +3934,7 @@ func webpushHandler(server *Server, client *Client, msg ircmsg.Message, rb *Resp
 
 	if err := webpush.SanityCheckWebPushEndpoint(endpoint); err != nil {
 		rb.Add(nil, server.name, "FAIL", "WEBPUSH", "INVALID_PARAMS", subcommand, client.t("Invalid web push URL"))
+		return false
 	}
 
 	switch subcommand {

Original file line number	Diff line number	Diff line change
`@@ -3934,6 +3934,7 @@ func webpushHandler(server Server, client Client, msg ircmsg.Message, rb *Resp`
`3934`	`3934`
`3935`	`3935`	`if err := webpush.SanityCheckWebPushEndpoint(endpoint); err != nil {`
`3936`	`3936`	`rb.Add(nil, server.name, "FAIL", "WEBPUSH", "INVALID_PARAMS", subcommand, client.t("Invalid web push URL"))`
	`3937`	`+ return false`
`3937`	`3938`	`}`
`3938`	`3939`
`3939`	`3940`	`switch subcommand {`