enforce max-keys

Author: thatcher-gaming

default.yaml

@@ -1094,7 +1094,7 @@ metadata:
     # how many keys can a client subscribe to? 
     # set to 0 to disable subscriptions or -1 to allow unlimited subscriptions.
     max-subs: 100
-    # how many keys can a given target store? set to -1 to allow unlimited keys.
+    # how many keys can a user store about themselves? set to -1 to allow unlimited keys.
     max-keys: 1000
 
 # experimental support for mobile push notifications

irc/config.go

@@ -728,7 +728,7 @@ type Config struct {
 		Enabled       bool
 		MaxSubs       int `yaml:"max-subs"`
 		MaxKeys       int `yaml:"max-keys"`
-		MaxValueBytes int `yaml:"max-value-length"`
+		MaxValueBytes int `yaml:"max-value-length"` // todo: currently unenforced!!
 	}
 
 	WebPush struct {

irc/getters.go

@@ -935,6 +935,17 @@ func (channel *Channel) ClearMetadata() MetadataStore {
 	return oldMap
 }
 
+func (channel *Channel) CountMetadata() int {
+	channel.stateMutex.RLock()
+	defer channel.stateMutex.RUnlock()
+
+	if channel.metadata == nil {
+		return 0
+	}
+
+	return len(channel.metadata)
+}
+
 func (client *Client) GetMetadata(key string) (string, error) {
 	client.stateMutex.RLock()
 	defer client.stateMutex.RUnlock()
@@ -982,3 +993,14 @@ func (client *Client) ClearMetadata() MetadataStore {
 
 	return oldMap
 }
+
+func (client *Client) CountMetadata() int {
+	client.stateMutex.RLock()
+	defer client.stateMutex.RUnlock()
+
+	if client.metadata == nil {
+		return 0
+	}
+
+	return len(client.metadata)
+}

irc/handlers.go

@@ -3167,6 +3167,14 @@ func metadataHandler(server *Server, client *Client, msg ircmsg.Message, rb *Res
 				return
 			}
 
+			maxKeys := server.Config().Metadata.MaxKeys
+			isSelf := targetClient != nil && client == targetClient
+
+			if isSelf && maxKeys > 0 && t.CountMetadata() >= maxKeys {
+				rb.Add(nil, server.name, "FAIL", "METADATA", "LIMIT_REACHED", client.nick, client.t("You have too many keys set on yourself"))
+				return
+			}
+
 			server.logger.Debug("metadata", "setting", key, value, "on", target)
 
 			t.SetMetadata(key, value)

irc/metadata.go

@@ -23,6 +23,7 @@ type MetadataHaver = interface {
 	DeleteMetadata(key string)
 	ListMetadata() MetadataStore
 	ClearMetadata() MetadataStore
+	CountMetadata() int
 }
 
 func notifySubscribers(server *Server, session *Session, target string, key string, value string) {