chore: don't return emission results

Don't expose emission results when evaluating emissions

Author: jsolaas

src/libecalc/presentation/yaml/model.py

@@ -372,7 +372,7 @@ def evaluate_energy_usage(self):
 
                 self._consumer_results[energy_component.id] = consumer_result
 
-    def evaluate_emissions(self) -> dict[str, dict[str, TimeSeriesStreamDayRate]]:
+    def evaluate_emissions(self):
         """
         Calculate emissions for fuel consumers and emitters
 
@@ -388,8 +388,6 @@ def evaluate_emissions(self) -> dict[str, dict[str, TimeSeriesStreamDayRate]]:
                 if emission_result is not None:
                     self._emission_results[energy_component.id] = emission_result
 
-        return self._emission_results
-
     def get_graph_result(self) -> GraphResult:
         return GraphResult(
             graph=self._get_graph(),

tests/libecalc/presentation/yaml/test_venting_emitter.py

@@ -338,10 +338,26 @@ def test_venting_emitter_condition_mapping_and_evaluation(
         resources = {
             prod_data_timeseries.name: prod_data_resource,
         }
-        yaml_direct_emitter = YamlVentingEmitterDirectTypeBuilder().with_test_data().validate()
-        yaml_direct_emitter.emissions[0].rate.value = "SIM1;EMISSION_RATE"
-
-        yaml_direct_emitter.emissions[0].rate.condition = "SIM1;CONDITION_VAR > 3"
+        yaml_direct_emitter = (
+            YamlVentingEmitterDirectTypeBuilder()
+            .with_test_data()
+            .with_emissions(
+                [
+                    YamlVentingEmissionBuilder()
+                    .with_test_data()
+                    .with_name("CO2")
+                    .with_rate(
+                        YamlEmissionRateBuilder()
+                        .with_test_data()
+                        .with_value("SIM1;EMISSION_RATE")
+                        .with_condition("SIM1;CONDITION_VAR > 3")
+                        .validate()
+                    )
+                    .validate()
+                ]
+            )
+            .validate()
+        )
         asset = (
             yaml_asset_builder_factory()
             .with_start("2020-01-01")
@@ -365,7 +381,16 @@ def test_venting_emitter_condition_mapping_and_evaluation(
             output_frequency=Frequency.NONE,
         )
         model.validate_for_run()
-        result = model.evaluate_emissions()
+        model.evaluate_emissions()
+
+        installations = model.get_installations()
+        assert len(installations) == 1
+        emitters = installations[0].get_emitters()
+        assert len(emitters) == 1
+        emitter = emitters[0]
 
         # First period does not meet condition, second period meets condition
-        assert result["VentingEmitterDirectTypeDefault"]["ventingemissiondefault"].values == [0.0, 0.002]
+        emissions = emitter.get_emissions()
+        assert len(emissions) == 1
+        emission = emissions["co2"]
+        assert emission.values == [0.0, 0.002]