Skip to content

Commit d4707d1

Browse files
authored
Roll engine to 9a6c64de8a4694cef59a338cd33ac1a9e7d23d9d (#141870)
Includes the Engine roll from flutter/flutter#141841 A new version of Dart is having trouble with the tool integration test test `passing one file with errors are detected`: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20tool_integration_tests_2_4/31851/overview. However the analysis server emits the expected errors when we give it both the file without issues and the file with issues. My guess is that the analysis server has changed it's behavior slightly when supplied with a single malformed file. Since the Dart roll is >20 dev versions behind, and this is the only failing presubmit test, and it's testing something a bit weird, I suggest we investigate the right way to test the thing that test was attempting to cover as a follow-up.
1 parent 0487931 commit d4707d1

File tree

2 files changed

+5
-19
lines changed

2 files changed

+5
-19
lines changed

bin/internal/engine.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
d1afda52d254f5f1faf79e51fe430d912d6db3ee
1+
9a6c64de8a4694cef59a338cd33ac1a9e7d23d9d

packages/flutter_tools/test/integration.shard/analyze_once_test.dart

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ void main() {
3333
expect(result.stderr, contains(exitMessageContains));
3434
}
3535

36-
void createDotPackages(String projectPath, [bool nullSafe = false]) {
36+
void createDotPackages(String projectPath) {
3737
final StringBuffer flutterRootUri = StringBuffer('file://');
3838
final String canonicalizedFlutterRootPath = fileSystem.path.canonicalize(getFlutterRoot());
3939
if (platform.isWindows) {
@@ -51,19 +51,19 @@ void main() {
5151
"name": "flutter",
5252
"rootUri": "$flutterRootUri/packages/flutter",
5353
"packageUri": "lib/",
54-
"languageVersion": "2.12"
54+
"languageVersion": "3.0"
5555
},
5656
{
5757
"name": "sky_engine",
5858
"rootUri": "$flutterRootUri/bin/cache/pkg/sky_engine",
5959
"packageUri": "lib/",
60-
"languageVersion": "2.12"
60+
"languageVersion": "3.0"
6161
},
6262
{
6363
"name": "flutter_project",
6464
"rootUri": "../",
6565
"packageUri": "lib/",
66-
"languageVersion": "${nullSafe ? "2.12" : "2.7"}"
66+
"languageVersion": "2.7"
6767
}
6868
]
6969
}
@@ -109,20 +109,6 @@ void main() {
109109
);
110110
});
111111

112-
testWithoutContext('passing one file with errors are detected', () async {
113-
await runCommand(
114-
arguments: <String>['analyze', '--no-pub', errorFile.path],
115-
statusTextContains: <String>[
116-
'Analyzing error.dart',
117-
"error $analyzerSeparator Target of URI doesn't exist",
118-
"error $analyzerSeparator Expected to find ';'",
119-
'error $analyzerSeparator Unterminated string literal',
120-
],
121-
exitMessageContains: '3 issues found',
122-
exitCode: 1
123-
);
124-
});
125-
126112
testWithoutContext('passing more than one file with errors', () async {
127113
await runCommand(
128114
arguments: <String>['analyze', '--no-pub', libMain.path, errorFile.path],

0 commit comments

Comments
 (0)