Skip to content

Commit 7fe412c

Browse files
authored
[image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property (flutter#3783)
`testSaveImageWithPickerInfo_ShouldSaveWithTheCorrectExtentionAndMetaData` passed on iOS 16 but not iOS 16.2. For some reason the latter doesn't want maintain `kCGImagePropertyExifMakerNote`. Swap to `kCGImagePropertyExifUserComment` which does work on both versions, and tests the same thing: metadata can be written and read. Fixes flutter#125257
1 parent cd15620 commit 7fe412c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

packages/image_picker/image_picker_ios/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## NEXT
2+
* Updates metadata unit test to work on iOS 16.2.
3+
14
## 0.8.7+3
25

36
* Updates pigeon to fix warnings with clang 15.

packages/image_picker/image_picker_ios/example/ios/RunnerTests/PhotoAssetUtilTests.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ - (void)testSaveImageWithPickerInfo_ShouldSaveWithTheCorrectExtentionAndMetaData
7676
NSDictionary *dummyInfo = @{
7777
UIImagePickerControllerMediaMetadata : @{
7878
(__bridge NSString *)kCGImagePropertyExifDictionary :
79-
@{(__bridge NSString *)kCGImagePropertyExifMakerNote : @"aNote"}
79+
@{(__bridge NSString *)kCGImagePropertyExifUserComment : @"aNote"}
8080
}
8181
};
8282
UIImage *imageJPG = [UIImage imageWithData:ImagePickerTestImages.JPGTestData];
@@ -86,7 +86,7 @@ - (void)testSaveImageWithPickerInfo_ShouldSaveWithTheCorrectExtentionAndMetaData
8686
NSData *data = [NSData dataWithContentsOfFile:savedPathJPG];
8787
NSDictionary *meta = [FLTImagePickerMetaDataUtil getMetaDataFromImageData:data];
8888
XCTAssertEqualObjects(meta[(__bridge NSString *)kCGImagePropertyExifDictionary]
89-
[(__bridge NSString *)kCGImagePropertyExifMakerNote],
89+
[(__bridge NSString *)kCGImagePropertyExifUserComment],
9090
@"aNote");
9191
}
9292

0 commit comments

Comments
 (0)