Skip to content

Commit 5bc70c7

Browse files
authored
[go_router] Remove unused navigator keys (flutter#3708)
Remove unused navigator keys from GoRouteData and ShellRouteData. Closes flutter#124497
1 parent d155228 commit 5bc70c7

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

packages/go_router/CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 6.5.9
2+
3+
- Removes navigator keys from `GoRouteData` and `ShellRouteData`.
4+
15
## 6.5.8
26

37
- Adds name parameter to `TypedGoRoute`
@@ -16,7 +20,7 @@
1620

1721
## 6.5.4
1822

19-
- Remove navigator keys from `TypedGoRoute` and `TypedShellRoute`.
23+
- Removes navigator keys from `TypedGoRoute` and `TypedShellRoute`.
2024

2125
## 6.5.3
2226

packages/go_router/lib/src/route_data.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,6 @@ abstract class GoRouteData extends RouteData {
121121
static final Expando<GoRouteData> _stateObjectExpando = Expando<GoRouteData>(
122122
'GoRouteState to GoRouteData expando',
123123
);
124-
125-
/// [navigatorKey] is used to point to a certain navigator
126-
///
127-
/// It will use the given key to find the right navigator for [GoRoute]
128-
GlobalKey<NavigatorState>? get navigatorKey => null;
129124
}
130125

131126
/// Base class for supporting
@@ -208,9 +203,6 @@ abstract class ShellRouteData extends RouteData {
208203
Expando<ShellRouteData>(
209204
'GoRouteState to ShellRouteData expando',
210205
);
211-
212-
/// It will be used to instantiate [Navigator] with the given key
213-
GlobalKey<NavigatorState>? get navigatorKey => null;
214206
}
215207

216208
/// A superclass for each typed route descendant

packages/go_router/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: go_router
22
description: A declarative router for Flutter based on Navigation 2 supporting
33
deep linking, data-driven routes and more
4-
version: 6.5.8
4+
version: 6.5.9
55
repository: https://github.com/flutter/packages/tree/main/packages/go_router
66
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22
77

0 commit comments

Comments
 (0)