Skip to content

Commit 3c1c3e2

Browse files
authored
Add comments to build_and_test_linux_unopt_debug (flutter#17567)
Clarify that the test depends on the framework repo. It may fail if the framework repo is broken, so the engine committer don't need to be in panic.
1 parent 1b6b609 commit 3c1c3e2

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.cirrus.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ task:
7474
test_host_script: |
7575
cd $ENGINE_PATH/src
7676
./flutter/testing/run_tests.sh host_release
77+
78+
# The following test depends on Flutter framework repo. It may fail if the
79+
# framework repo is currently broken.
7780
- name: build_and_test_linux_unopt_debug
7881
compile_host_script: |
7982
cd $ENGINE_PATH/src
@@ -97,6 +100,9 @@ task:
97100
mkdir -p $FRAMEWORK_PATH
98101
cd $FRAMEWORK_PATH
99102
git clone https://github.com/flutter/flutter.git
103+
verify_framework_script:
104+
- echo "Checking that the framework Cirrus test is not currently broken..."
105+
- curl -s https://api.cirrus-ci.com/github/flutter/flutter.json | grep -q passing
100106
test_web_script: |
101107
cd $FRAMEWORK_PATH/flutter/dev/integration_tests/web
102108
../../../bin/flutter config --local-engine=host_debug_unopt --no-analytics --enable-web

0 commit comments

Comments
 (0)