Skip to content

Commit 9f7d80d

Browse files
committed
Add capabilities to modifier managers
Addresses deprecation `implicit-modifier-manager-capabilities`: Custom modifier managers must define their capabilities using the capabilities() helper function
1 parent b440ed0 commit 9f7d80d

File tree

6 files changed

+360
-8
lines changed

6 files changed

+360
-8
lines changed

addon/modifier.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import Ember from 'ember';
2+
import { setModifierManager, capabilities } from '@ember/modifier';
3+
4+
if (!capabilities) {
5+
// Exported to global with typo up till #18266
6+
capabilities = Ember._modifierManagerCapabilties;
7+
}
8+
9+
export { setModifierManager, capabilities };

addon/modifiers/did-insert.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import Ember from 'ember';
1+
import { setModifierManager, capabilities } from '../modifier';
22

33
/**
44
The `{{did-insert}}` element modifier is activated when an element is
@@ -44,8 +44,10 @@ import Ember from 'ember';
4444
@method did-insert
4545
@public
4646
*/
47-
export default Ember._setModifierManager(
47+
export default setModifierManager(
4848
() => ({
49+
capabilities: capabilities('3.13'),
50+
4951
createModifier() {},
5052

5153
installModifier(_state, element, args) {

addon/modifiers/did-update.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import Ember from 'ember';
1+
import { setModifierManager, capabilities } from '../modifier';
22

33
/**
44
The `{{did-update}}` element modifier is activated when any of its arguments
@@ -56,8 +56,10 @@ import Ember from 'ember';
5656
@method did-update
5757
@public
5858
*/
59-
export default Ember._setModifierManager(
59+
export default setModifierManager(
6060
() => ({
61+
capabilities: capabilities('3.13'),
62+
6163
createModifier() {
6264
return { element: null };
6365
},

addon/modifiers/will-destroy.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import Ember from 'ember';
1+
import { setModifierManager, capabilities } from '../modifier';
22

33
/**
44
The `{{will-destroy}}` element modifier is activated immediately before the element
@@ -38,8 +38,10 @@ import Ember from 'ember';
3838
@method will-destroy
3939
@public
4040
*/
41-
export default Ember._setModifierManager(
41+
export default setModifierManager(
4242
() => ({
43+
capabilities: capabilities('3.13'),
44+
4345
createModifier() {
4446
return { element: null };
4547
},

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"test:all": "ember try:each"
2424
},
2525
"dependencies": {
26-
"ember-cli-babel": "^7.1.2",
26+
"ember-cli-babel": "^7.10.0",
2727
"ember-modifier-manager-polyfill": "^1.0.1"
2828
},
2929
"devDependencies": {

0 commit comments

Comments
 (0)