Merge pull request #1 from embassy-rs/iteration-order

fix: release should iterate over dependents not dependencies

Author: lulf

src/bump.rs

@@ -11,9 +11,11 @@ pub fn bump(ctx: &mut Context, name: &CrateId, new_version: &str) -> Result<(),
     c.version = new_version.to_string();
 
     update_crate(c, new_version)?;
-    for dep in &ctx.reverse_deps[name] {
-        println!("Updating {name}-{old_version} -> {new_version} for {dep}");
-        update_deps(&ctx.crates[dep], name, new_version)?;
+    if let Some(reverse_deps) = ctx.reverse_deps.get(name) {
+        for dep in reverse_deps {
+            println!("Updating {name}-{old_version} -> {new_version} for {dep}");
+            update_deps(&ctx.crates[dep], name, new_version)?;
+        }
     }
 
     let c = ctx.crates.get(name).unwrap();

src/cmd/prepare_release.rs

@@ -36,7 +36,7 @@ pub fn run(ctx: &mut Context, args: Args) -> Result<()> {
     let mut to_bump = std::collections::HashMap::new();
     for crate_name in crate_names {
         if !to_bump.contains_key(crate_name) {
-            let deps = ctx.recursive_dependencies(std::iter::once(crate_name.as_str()));
+            let deps = ctx.recursive_dependents(std::iter::once(crate_name.as_str()));
             for dep_crate_name in deps {
                 let c = ctx.crates.get(&dep_crate_name).unwrap();
                 if c.publish && !to_bump.contains_key(&dep_crate_name) {
@@ -63,7 +63,7 @@ pub fn run(ctx: &mut Context, args: Args) -> Result<()> {
     for name in keys {
         let (rtype, _) = to_bump[&name];
         if rtype == ReleaseType::Minor {
-            let deps = ctx.recursive_dependencies(std::iter::once(name.as_str()));
+            let deps = ctx.recursive_dependents(std::iter::once(name.as_str()));
             for dep_crate_name in deps {
                 if let Some((ReleaseType::Patch, newver)) = to_bump.get(&dep_crate_name) {
                     let v = semver::Version::parse(newver)?;
@@ -94,7 +94,7 @@ pub fn run(ctx: &mut Context, args: Args) -> Result<()> {
     println!();
     let mut processed = HashSet::new();
     for crate_name in crate_names {
-        let deps = ctx.recursive_dependencies(std::iter::once(crate_name.as_str()));
+        let deps = ctx.recursive_dependents(std::iter::once(crate_name.as_str()));
         for dep_crate_name in deps {
             let c = ctx.crates.get(&dep_crate_name).unwrap();
             if c.publish && !processed.contains(&dep_crate_name) {
@@ -107,7 +107,7 @@ pub fn run(ctx: &mut Context, args: Args) -> Result<()> {
     println!();
     println!("# Run these commands to publish the crate and dependents:");
     for crate_name in crate_names {
-        let deps = ctx.recursive_dependencies(std::iter::once(crate_name.as_str()));
+        let deps = ctx.recursive_dependents(std::iter::once(crate_name.as_str()));
         for dep_crate_name in deps {
             if !processed.contains(&dep_crate_name) {
                 processed.insert(dep_crate_name.clone());