feat(@embark/blockchain): make GanacheCLI the default dev blockchain

Set Ganache as a blockchain client that doesn't need to be started.
Set it as the default client, at least for development.
Move all blockchain related stuff in the blockchain component
Includes a fix by @emmizle to fix the WS connection in the proxy

Author: jrainville

dapps/templates/boilerplate/config/blockchain.js

@@ -4,10 +4,11 @@ module.exports = {
   // default applies to all environments
   default: {
     enabled: true,
-    client: "geth" // Can be geth or parity (default:geth)
+    client: "geth" // Can be ganache-cli, geth or parity (default: geth)
   },
 
   development: {
+    client: 'ganache-cli',
     clientConfig: {
       miningMode: 'dev' // Mode in which the node mines. Options: dev, auto, always, off
     }

dapps/templates/demo/config/blockchain.js

@@ -4,10 +4,11 @@ module.exports = {
   // default applies to all environments
   default: {
     enabled: true,
-    client: "geth" // Can be geth or parity (default:geth)
+    client: "geth" // Can be ganache-cli, geth or parity (default: geth)
   },
 
   development: {
+    client: 'ganache-cli',
     clientConfig: {
       miningMode: 'dev' // Mode in which the node mines. Options: dev, auto, always, off
     }

dapps/tests/app/config/blockchain.js

@@ -4,10 +4,11 @@ module.exports = {
   // default applies to all environments
   default: {
     enabled: true,
-    client: "geth" // Can be geth or parity (default:geth)
+    client: "geth" // Can be ganache-cli, geth or parity (default: geth)
   },
 
   development: {
+    client: 'ganache-cli',
     clientConfig: {
       miningMode: 'dev' // Mode in which the node mines. Options: dev, auto, always, off
     },

dapps/tests/app/test/another_storage_spec.js

@@ -12,6 +12,7 @@ config({
       {
         "mnemonic": "example exile argue silk regular smile grass bomb merge arm assist farm",
         balance: "5ether",
+        hdpath: "m/44'/1'/0'/0/",
         numAddresses: 10
       }
     ]
@@ -49,7 +50,6 @@ contract("AnotherStorage", function() {
 
     for (let i = 1; i < numAddresses - 3; i++) {
       balance = await web3.eth.getBalance(accounts[i]);
-      console.log('Account', i , balance);
       assert.strictEqual(parseInt(balance, 10), 5000000000000000000, `Account ${i} doesn't have the balance set`);
     }
   });

packages/core/core/constants.json

@@ -40,8 +40,10 @@
     "call": "eth_call",
     "clients": {
       "geth": "geth",
-      "parity": "parity"
+      "parity": "parity",
+      "ganache": "ganache-cli"
     },
+    "defaultMnemonic": "example exile argue silk regular smile grass bomb merge arm assist farm",
     "blockchainReady": "blockchainReady",
     "blockchainExit": "blockchainExit",
     "defaults": {

packages/core/core/src/configDefaults.ts

@@ -26,7 +26,7 @@ export function getBlockchainDefaults(env) {
       miningMode: 'dev' // Mode in which the node mines. Options: dev, auto, always, off
     },
     enabled: true,
-    client: constants.blockchain.clients.geth,
+    client: constants.blockchain.clients.ganache,
     proxy: true,
     datadir: `.embark/${env}/datadir`,
     rpcHost: "localhost",

packages/core/engine/package.json

@@ -51,7 +51,6 @@
     "embark-authenticator": "^5.2.0-nightly.3",
     "embark-basic-pipeline": "^5.2.0-nightly.3",
     "embark-blockchain": "^5.2.0-nightly.3",
-    "embark-blockchain-client": "^5.1.1",
     "embark-code-runner": "^5.2.0-nightly.3",
     "embark-communication": "^5.2.0-nightly.3",
     "embark-compiler": "^5.2.0-nightly.3",

packages/core/engine/src/index.ts

@@ -246,7 +246,6 @@ export class Engine {
 
   blockchainStackComponents() {
     this.registerModulePackage('embark-blockchain', { plugins: this.plugins, ipc: this.ipc });
-    this.registerModulePackage('embark-blockchain-client');
     this.registerModulePackage('embark-process-logs-api-manager');
   }
 
@@ -259,7 +258,6 @@ export class Engine {
     this.registerModulePackage('embark-compiler', { plugins: this.plugins, isCoverage: options.isCoverage });
     this.registerModulePackage('embark-contracts-manager', { plugins: this.plugins, compileOnceOnly: options.compileOnceOnly });
     this.registerModulePackage('embark-deployment', { plugins: this.plugins, onlyCompile: options.onlyCompile });
-    this.registerModulePackage('embark-blockchain-client');
     this.registerModulePackage('embark-storage');
     this.registerModulePackage('embark-communication');
     this.registerModulePackage('embark-namesystem');
@@ -269,6 +267,7 @@ export class Engine {
 
   blockchainComponents() {
     // plugins
+    this.registerModulePackage('embark-ganache');
     this.registerModulePackage('embark-geth');
     this.registerModulePackage('embark-parity');
   }
@@ -287,7 +286,6 @@ export class Engine {
   }
 
   contractsComponents(_options) {
-    this.registerModulePackage('embark-ganache');
     this.registerModulePackage('embark-ethereum-blockchain-client');
     this.registerModulePackage('embark-web3');
     this.registerModulePackage('embark-accounts-manager');

packages/core/engine/tsconfig.json

@@ -94,9 +94,6 @@
     {
       "path": "../../stack/blockchain"
     },
-    {
-      "path": "../../stack/blockchain-client"
-    },
     {
       "path": "../../stack/communication"
     },

packages/embark/src/test/config.js

@@ -17,7 +17,7 @@ describe('embark.Config', function () {
       config.loadBlockchainConfigFile();
       let expectedConfig = {
         "enabled": true,
-        "client": "geth",
+        "client": "ganache-cli",
         "proxy": true,
         "clientConfig": {
           "miningMode": "dev"
@@ -54,7 +54,7 @@ describe('embark.Config', function () {
     it('should convert Ether units', function () {
       let expectedConfig = {
         "enabled": true,
-        "client": "geth",
+        "client": "ganache-cli",
         "proxy": true,
         "clientConfig": {
           "miningMode": "dev"
@@ -107,7 +107,7 @@ describe('embark.Config', function () {
     it('should accept unitless gas values', function () {
       let expectedConfig = {
         "enabled": true,
-        "client": "geth",
+        "client": "ganache-cli",
         "proxy": true,
         "clientConfig": {
           "miningMode": "dev"
@@ -160,7 +160,7 @@ describe('embark.Config', function () {
     it('should use the specified endpoint', () => {
       let expectedConfig = {
         "enabled": true,
-        "client": "geth",
+        "client": "ganache-cli",
         "proxy": true,
         "clientConfig": {
           "miningMode": "dev"