Skip to content

Commit 53dc751

Browse files
jrainvilleiurimatias
authored andcommitted
fix(@embark/ganache): make embark blockchain exit when using Ganache
1 parent c624582 commit 53dc751

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

packages/plugins/ganache/src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class Ganache {
2020
this._registerStatusCheck();
2121
this._getProvider(); // No need to return anything, we just want to populate currentProvider
2222
this.embark.logger.info(__('Blockchain node is ready').cyan);
23-
cb();
23+
cb(null, true);
2424
},
2525
stopFn: (cb) => {
2626
this.currentProvider = null;

packages/stack/blockchain/src/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ export default class Blockchain {
7878
return cb(null, true);
7979
}
8080
// start node
81-
client.launchFn.call(client, () => {
81+
client.launchFn.call(client, (_err, isVM) => {
8282
started();
83-
cb();
83+
cb(null, isVM);
8484
});
8585
});
8686
});

packages/stack/proxy/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ export default class ProxyManager {
130130

131131
// HTTP
132132
this.httpProxy = await new Proxy({
133-
endpoint,
134133
events: this.events,
135134
isWs: false,
136135
logger: this.logger,

0 commit comments

Comments
 (0)