self-review

Author: akim-bow

src/cookies.ts

@@ -125,7 +125,7 @@ type Updater<T> = T | ((value: T) => T)
 export class Cookie<T> implements ElysiaCookie {
 	constructor(
 		private name: string,
-		// Modifications here lead to changes in the response headers. Initially empty.
+		// Modifications here lead to changes in the response headers. Empty at the start of a request.
 		private jar: Record<string, ElysiaCookie>,
 		private readonly initial: Partial<ElysiaCookie> = {}
 	) {}

test/cookie/unchanged.test.ts

@@ -108,7 +108,7 @@ describe('Cookie - Unchanged Values', () => {
 		expect(response.headers.getAll('set-cookie').length).toBeGreaterThan(0)
 	})
 
-	it('cookie handling should be idempotent', async () => {
+	it('should idempotently create headers on cookie modifications', async () => {
 		const app = new Elysia().post('/update', ({ cookie: { data } }) => {
 			// Set to same value as incoming cookie
 			data.value = { id: 123, name: 'test' }
@@ -132,7 +132,6 @@ describe('Cookie - Unchanged Values', () => {
 			})
 		)
 
-		// Should not send Set-Cookie since value didn't change
 		expect(secondRes.headers.getAll('set-cookie').length).toBe(1)
 	})