Skip to content

Commit eac33c3

Browse files
committed
Add @deprecated to functions related to levelpad
1 parent af5d02f commit eac33c3

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/logger/lib/logger/formatter.ex

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,11 @@ defmodule Logger.Formatter do
9999
end
100100
end
101101

102+
defp compile_code(:levelpad) do
103+
IO.warn "$levelpad in Logger message format is deprecated, please remove it"
104+
:levelpad
105+
end
106+
102107
defp compile_code(key) when key in @valid_patterns, do: key
103108

104109
defp compile_code(key) when is_atom(key) do
@@ -163,7 +168,6 @@ defmodule Logger.Formatter do
163168
defp output(:levelpad, level, _, _, _), do: levelpad(level)
164169
defp output(other, _, _, _, _), do: other
165170

166-
# TODO: Deprecate me on Elixir v1.13+ or later
167171
defp levelpad(:info), do: " "
168172
defp levelpad(:warn), do: " "
169173
defp levelpad(_), do: ""

lib/logger/test/logger/formatter_test.exs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ defmodule Logger.FormatterTest do
9090
[["foo", 61, "bar", 32], " ", "hello"]
9191
end
9292

93+
@deprecated "levelpad is deprecated"
9394
test "padding takes account of length of level" do
9495
compiled = compile("[$level] $levelpad $message")
9596
assert format(compiled, :error, "hello", nil, []) == ["[", "error", "] ", "", " ", "hello"]

0 commit comments

Comments
 (0)