Skip to content

Commit 2c3e902

Browse files
committed
Add @deprecated to functions related to levelpad
1 parent af5d02f commit 2c3e902

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/logger/lib/logger/formatter.ex

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,15 @@ defmodule Logger.Formatter do
160160
defp output(:node, _, _, _, _), do: Atom.to_string(node())
161161
defp output(:metadata, _, _, _, []), do: ""
162162
defp output(:metadata, _, _, _, meta), do: metadata(meta)
163+
@deprecated "levelpad is deprecated"
163164
defp output(:levelpad, level, _, _, _), do: levelpad(level)
164165
defp output(other, _, _, _, _), do: other
165166

166-
# TODO: Deprecate me on Elixir v1.13+ or later
167+
@deprecated "levelpad is deprecated"
167168
defp levelpad(:info), do: " "
169+
@deprecated "levelpad is deprecated"
168170
defp levelpad(:warn), do: " "
171+
@deprecated "levelpad is deprecated"
169172
defp levelpad(_), do: ""
170173

171174
defp metadata([{key, value} | metadata]) do

lib/logger/test/logger/formatter_test.exs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ defmodule Logger.FormatterTest do
9090
[["foo", 61, "bar", 32], " ", "hello"]
9191
end
9292

93+
@deprecated "levelpad is deprecated"
9394
test "padding takes account of length of level" do
9495
compiled = compile("[$level] $levelpad $message")
9596
assert format(compiled, :error, "hello", nil, []) == ["[", "error", "] ", "", " ", "hello"]

0 commit comments

Comments
 (0)