Skip to content

Commit 1598fc2

Browse files
committed
spec: update inspector-binding.js
* nodejs/node#22251 * nodejs/node#20137
1 parent 9d3502f commit 1598fc2

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

spec/fixtures/module/inspector-binding.js

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
const inspector = require('inspector')
22
const path = require('path')
3+
const { pathToFileURL } = require('url')
34

45
// This test case will set a breakpoint 4 lines below
56
function debuggedFunction () {
@@ -51,21 +52,13 @@ function testSampleDebugSession () {
5152
}
5253
const session = new inspector.Session()
5354
session.connect()
54-
let secondSessionOpened = false
55-
const secondSession = new inspector.Session()
56-
try {
57-
secondSession.connect()
58-
secondSessionOpened = true
59-
} catch (error) {
60-
// expected as the session already exists
61-
}
6255
session.on('Debugger.paused',
6356
(notification) => debuggerPausedCallback(session, notification))
6457
let cbAsSecondArgCalled = false
6558
session.post('Debugger.enable', () => { cbAsSecondArgCalled = true })
6659
session.post('Debugger.setBreakpointByUrl', {
67-
'lineNumber': 8,
68-
'url': path.resolve(__dirname, __filename),
60+
'lineNumber': 9,
61+
'url': pathToFileURL(path.resolve(__dirname, __filename)).toString(),
6962
'columnNumber': 0,
7063
'condition': ''
7164
})
@@ -76,7 +69,6 @@ function testSampleDebugSession () {
7669
process.send({
7770
'cmd': 'assert',
7871
'debuggerEnabled': cbAsSecondArgCalled,
79-
'secondSessionOpened': secondSessionOpened,
8072
'success': (cur === 5) && (failures.length === 0)
8173
})
8274
}

spec/node-spec.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,10 +247,9 @@ describe('node feature', () => {
247247
stdio: ['ipc']
248248
})
249249

250-
child.on('message', ({ cmd, debuggerEnabled, secondSessionOpened, success }) => {
250+
child.on('message', ({ cmd, debuggerEnabled, success }) => {
251251
if (cmd === 'assert') {
252252
expect(debuggerEnabled).to.be.true()
253-
expect(secondSessionOpened).to.be.true()
254253
expect(success).to.be.true()
255254
done()
256255
}

0 commit comments

Comments
 (0)