Skip to content

Commit 60774a3

Browse files
mmaiettammaietta
authored
fix: resolve CI flakiness due to lzma-native dependency (#8342)
1 parent 1c4ec12 commit 60774a3

File tree

3 files changed

+7
-219
lines changed

3 files changed

+7
-219
lines changed

‎.changeset/twenty-pianos-rule.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
3+
---
4+
5+
fix: resolve CI flakiness due to lzma-native dependency

‎test/snapshots/BuildTest.js.snap

Lines changed: 0 additions & 216 deletions
Original file line numberDiff line numberDiff line change
@@ -927,199 +927,11 @@ Object {
927927
},
928928
},
929929
},
930-
"node_modules": Object {
931-
"files": Object {
932-
"node-addon-api": Object {
933-
"files": Object {
934-
"LICENSE.md": Object {
935-
"size": "<size>",
936-
},
937-
"common.gypi": Object {
938-
"size": "<size>",
939-
},
940-
"except.gypi": Object {
941-
"size": "<size>",
942-
},
943-
"index.js": Object {
944-
"size": "<size>",
945-
},
946-
"napi-inl.deprecated.h": Object {
947-
"size": "<size>",
948-
},
949-
"napi-inl.h": Object {
950-
"size": "<size>",
951-
},
952-
"napi.h": Object {
953-
"size": "<size>",
954-
},
955-
"node_api.gyp": Object {
956-
"size": "<size>",
957-
},
958-
"noexcept.gypi": Object {
959-
"size": "<size>",
960-
},
961-
"nothing.c": Object {
962-
"size": "<size>",
963-
},
964-
"package-support.json": Object {
965-
"size": "<size>",
966-
},
967-
"package.json": Object {
968-
"size": "<size>",
969-
},
970-
"tools": Object {
971-
"files": Object {
972-
"README.md": Object {
973-
"size": "<size>",
974-
},
975-
"check-napi.js": Object {
976-
"size": "<size>",
977-
},
978-
"clang-format.js": Object {
979-
"size": "<size>",
980-
},
981-
"conversion.js": Object {
982-
"executable": true,
983-
"size": "<size>",
984-
},
985-
"eslint-format.js": Object {
986-
"size": "<size>",
987-
},
988-
},
989-
},
990-
},
991-
},
992-
},
993-
},
994930
"package.json": Object {
995931
"size": "<size>",
996932
},
997933
},
998934
},
999-
"lzma-native": Object {
1000-
"files": Object {
1001-
"LICENSE": Object {
1002-
"size": "<size>",
1003-
},
1004-
"bin": Object {
1005-
"files": Object {
1006-
"lzmajs": Object {
1007-
"executable": true,
1008-
"size": "<size>",
1009-
},
1010-
},
1011-
},
1012-
"index.js": Object {
1013-
"size": "<size>",
1014-
},
1015-
"liblzma-build.sh": Object {
1016-
"executable": true,
1017-
"size": "<size>",
1018-
},
1019-
"liblzma-config.sh": Object {
1020-
"executable": true,
1021-
"size": "<size>",
1022-
},
1023-
"package.json": Object {
1024-
"size": "<size>",
1025-
},
1026-
"prebuilds": Object {
1027-
"files": Object {
1028-
"darwin-arm64": Object {
1029-
"files": Object {
1030-
"electron.napi.node": Object {
1031-
"size": "<size>",
1032-
},
1033-
"node.napi.node": Object {
1034-
"size": "<size>",
1035-
},
1036-
},
1037-
},
1038-
"darwin-x64": Object {
1039-
"files": Object {
1040-
"electron.napi.node": Object {
1041-
"size": "<size>",
1042-
},
1043-
"node.napi.node": Object {
1044-
"size": "<size>",
1045-
},
1046-
},
1047-
},
1048-
"linux-arm64": Object {
1049-
"files": Object {
1050-
"electron.napi.node": Object {
1051-
"size": "<size>",
1052-
},
1053-
"node.napi.node": Object {
1054-
"size": "<size>",
1055-
},
1056-
},
1057-
},
1058-
"linux-x64": Object {
1059-
"files": Object {
1060-
"electron.napi.node": Object {
1061-
"size": "<size>",
1062-
},
1063-
"node.napi.node": Object {
1064-
"size": "<size>",
1065-
},
1066-
},
1067-
},
1068-
"win32-ia32": Object {
1069-
"files": Object {
1070-
"electron.napi.node": Object {
1071-
"size": "<size>",
1072-
},
1073-
"node.napi.node": Object {
1074-
"size": "<size>",
1075-
},
1076-
},
1077-
},
1078-
"win32-x64": Object {
1079-
"files": Object {
1080-
"electron.napi.node": Object {
1081-
"size": "<size>",
1082-
},
1083-
"node.napi.node": Object {
1084-
"size": "<size>",
1085-
},
1086-
},
1087-
},
1088-
},
1089-
},
1090-
"src": Object {
1091-
"files": Object {
1092-
"filter-array.cpp": Object {
1093-
"size": "<size>",
1094-
},
1095-
"index-parser.cpp": Object {
1096-
"size": "<size>",
1097-
},
1098-
"index-parser.h": Object {
1099-
"size": "<size>",
1100-
},
1101-
"liblzma-functions.cpp": Object {
1102-
"size": "<size>",
1103-
},
1104-
"liblzma-node.hpp": Object {
1105-
"size": "<size>",
1106-
},
1107-
"lzma-stream.cpp": Object {
1108-
"size": "<size>",
1109-
},
1110-
"module.cpp": Object {
1111-
"size": "<size>",
1112-
},
1113-
"mt-options.cpp": Object {
1114-
"size": "<size>",
1115-
},
1116-
"util.cpp": Object {
1117-
"size": "<size>",
1118-
},
1119-
},
1120-
},
1121-
},
1122-
},
1123935
"mimic-response": Object {
1124936
"files": Object {
1125937
"index.js": Object {
@@ -1248,34 +1060,6 @@ Object {
12481060
},
12491061
},
12501062
},
1251-
"node-gyp-build": Object {
1252-
"files": Object {
1253-
"LICENSE": Object {
1254-
"size": "<size>",
1255-
},
1256-
"bin.js": Object {
1257-
"executable": true,
1258-
"size": "<size>",
1259-
},
1260-
"build-test.js": Object {
1261-
"executable": true,
1262-
"size": "<size>",
1263-
},
1264-
"index.js": Object {
1265-
"size": "<size>",
1266-
},
1267-
"node-gyp-build.js": Object {
1268-
"size": "<size>",
1269-
},
1270-
"optional.js": Object {
1271-
"executable": true,
1272-
"size": "<size>",
1273-
},
1274-
"package.json": Object {
1275-
"size": "<size>",
1276-
},
1277-
},
1278-
},
12791063
"once": Object {
12801064
"files": Object {
12811065
"LICENSE": Object {

‎test/src/BuildTest.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -334,13 +334,13 @@ test.ifDevOrLinuxCi(
334334
copyright: "Copyright © 2018 ${author}",
335335
npmRebuild: true,
336336
onNodeModuleFile: filePath => {
337-
// Force include this directory in the pakage
337+
// Force include this directory in the package
338338
return filePath.includes("node_modules/three/examples")
339339
},
340340
files: [
341341
// test ignore pattern for node_modules defined as file set filter
342342
{
343-
filter: ["!node_modules/napi-build-utils/napi-build-utils-1.0.0.tgz", "!node_modules/node-abi/*"],
343+
filter: ["!node_modules/napi-build-utils/napi-build-utils-1.0.0.tgz", "!node_modules/node-abi/*", "!node_modules/**/eslint-format.js"],
344344
},
345345
],
346346
},
@@ -350,7 +350,6 @@ test.ifDevOrLinuxCi(
350350
it.dependencies = {
351351
debug: "4.1.1",
352352
"edge-cs": "1.2.1",
353-
"lzma-native": "8.0.6",
354353
keytar: "7.9.0",
355354
three: "0.160.0",
356355
}

0 commit comments

Comments
 (0)