[Build] Add support for publishing to maven central

build-conventions/build.gradle

@@ -26,8 +26,8 @@ group = "org.elasticsearch"
 
 // This project contains Checkstyle rule implementations used by IDEs which use a Java 11 runtime
 java {
-  targetCompatibility = 11
-  sourceCompatibility = 11
+  targetCompatibility = 17
+  sourceCompatibility = 17
 }
 
 gradlePlugin {
@@ -75,6 +75,7 @@ dependencies {
   api buildLibs.maven.model
   api buildLibs.shadow.plugin
   api buildLibs.apache.rat
+  api buildLibs.nmcp
   compileOnly buildLibs.checkstyle
   constraints {
     api("org.eclipse.platform:org.eclipse.osgi:3.18.300") {

build-conventions/src/main/java/org/elasticsearch/gradle/internal/conventions/PublishPlugin.java

@@ -14,6 +14,8 @@
 import com.github.jengelman.gradle.plugins.shadow.ShadowExtension;
 import com.github.jengelman.gradle.plugins.shadow.ShadowPlugin;
 
+import nmcp.NmcpPlugin;
+
 import org.elasticsearch.gradle.internal.conventions.info.GitInfo;
 import org.elasticsearch.gradle.internal.conventions.precommit.PomValidationPrecommitPlugin;
 import org.elasticsearch.gradle.internal.conventions.util.Util;
@@ -27,6 +29,7 @@
 import org.gradle.api.plugins.ExtensionContainer;
 import org.gradle.api.plugins.JavaLibraryPlugin;
 import org.gradle.api.plugins.JavaPlugin;
+import org.gradle.api.plugins.JavaPluginExtension;
 import org.gradle.api.provider.MapProperty;
 import org.gradle.api.provider.Provider;
 import org.gradle.api.provider.ProviderFactory;
@@ -65,6 +68,7 @@ public void apply(Project project) {
         project.getPluginManager().apply(MavenPublishPlugin.class);
         project.getPluginManager().apply(PomValidationPrecommitPlugin.class);
         project.getPluginManager().apply(LicensingPlugin.class);
+        project.getPluginManager().apply(NmcpPlugin.class);
         configureJavadocJar(project);
         configureSourcesJar(project);
         configurePomGeneration(project);
@@ -82,6 +86,11 @@ private void configurePublications(Project project) {
                 publication.from(project.getComponents().getByName("java"));
             }
         });
+        project.getPlugins().withType(JavaPlugin.class, plugin -> {
+            var javaPluginExtension = project.getExtensions().getByType(JavaPluginExtension.class);
+            javaPluginExtension.withJavadocJar();
+            javaPluginExtension.withSourcesJar();
+        });
         @SuppressWarnings("unchecked")
         var projectLicenses = (MapProperty<String, Provider<String>>) project.getExtensions().getExtraProperties().get("projectLicenses");
         publication.getPom().withXml(xml -> {

build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/BuildPluginFuncTest.groovy

@@ -123,8 +123,6 @@ class BuildPluginFuncTest extends AbstractGradleFuncTest {
         then:
         result.task(":assemble").outcome == TaskOutcome.SUCCESS
         file("build/distributions/hello-world.jar").exists()
-        file("build/distributions/hello-world-javadoc.jar").exists()
-        file("build/distributions/hello-world-sources.jar").exists()
         assertValidJar(file("build/distributions/hello-world.jar"))
     }
 
@@ -162,7 +160,6 @@ class BuildPluginFuncTest extends AbstractGradleFuncTest {
         result.task(":forbiddenPatterns").outcome == TaskOutcome.SUCCESS
         result.task(":validateModule").outcome == TaskOutcome.SUCCESS
         result.task(":splitPackagesAudit").outcome == TaskOutcome.SUCCESS
-        result.task(":validateElasticPom").outcome == TaskOutcome.SUCCESS
         // disabled but check for being on the task graph
         result.task(":forbiddenApisMain").outcome == TaskOutcome.SKIPPED
         result.task(":checkstyleMain").outcome == TaskOutcome.SKIPPED

build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/PublishPluginFuncTest.groovy

@@ -23,6 +23,209 @@ class PublishPluginFuncTest extends AbstractGradleFuncTest {
         configurationCacheCompatible = false
     }
 
+    def "project with plugin applied is considered for maven central publication"() {
+        given:
+        // required for JarHell to work
+        subProject(":libs:some-public-lib") << """
+            plugins {
+                id 'elasticsearch.java'
+                id 'elasticsearch.publish'
+            }
+
+            group = 'org.acme'
+            version = '1.0'
+        """
+
+        subProject(":libs:some-other-lib") << """
+            plugins {
+                id 'elasticsearch.java'
+                id 'elasticsearch.publish'
+            }
+
+            group = 'org.acme.xpack'
+            version = '1.0'
+        """
+
+        subProject(":libs:some-private-lib") << """
+            plugins {
+                id 'elasticsearch.java'
+            }
+
+            group = 'org.acme.xpack'
+            version = '1.0'
+        """
+
+        buildFile << """
+            plugins {
+                id 'com.gradleup.nmcp.aggregation'
+            }
+
+            version = "1.0"
+            group = 'org.acme'
+            description = "custom project description"
+            nmcpAggregation {
+              centralPortal {
+                username = 'acme'
+                password = 'acmepassword'
+                // publish manually from the portal
+                publishingType = "USER_MANAGED"
+              }
+              // this breaks project isolation but this is broken in elasticsearch build atm anyhow.
+              publishAllProjectsProbablyBreakingProjectIsolation()
+            }
+        """
+
+        when:
+        def result = gradleRunner(':zipAggregation').build()
+
+        then:
+        result.task(":zipAggregation").outcome == TaskOutcome.SUCCESS
+        file("build/nmcp/zip/aggregation.zip").exists()
+
+
+        def zip = zip("build/nmcp/zip/aggregation.zip")
+        zip.files().findAll { it.isDirectory() == false }.collect { it.name }.sort() == [
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-javadoc.jar",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-javadoc.jar.md5",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-javadoc.jar.sha1",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-javadoc.jar.sha256",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-javadoc.jar.sha512",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-sources.jar",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-sources.jar.md5",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-sources.jar.sha1",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-sources.jar.sha256",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0-sources.jar.sha512",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.jar",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.jar.md5",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.jar.sha1",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.jar.sha256",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.jar.sha512",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.module",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.module.md5",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.module.sha1",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.module.sha256",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.module.sha512",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.pom",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.pom.md5",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.pom.sha1",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.pom.sha256",
+            "org/acme/some-public-lib/1.0/some-public-lib-1.0.pom.sha512",
+
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-javadoc.jar",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-javadoc.jar.md5",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-javadoc.jar.sha1",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-javadoc.jar.sha256",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-javadoc.jar.sha512",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-sources.jar",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-sources.jar.md5",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-sources.jar.sha1",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-sources.jar.sha256",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0-sources.jar.sha512",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.jar",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.jar.md5",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.jar.sha1",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.jar.sha256",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.jar.sha512",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.module",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.module.md5",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.module.sha1",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.module.sha256",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.module.sha512",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.pom",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.pom.md5",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.pom.sha1",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.pom.sha256",
+            "org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.pom.sha512"
+        ]
+
+        assertXmlEquals(zip.file("org/acme/some-public-lib/1.0/some-public-lib-1.0.pom").read(),"""
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <!-- This module was also published with a richer model, Gradle metadata,  -->
+  <!-- which should be used instead. Do not delete the following line which  -->
+  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
+  <!-- that they should prefer consuming it instead. -->
+  <!-- do_not_remove: published-with-gradle-metadata -->
+  <modelVersion>4.0.0</modelVersion>
+  <groupId>org.acme</groupId>
+  <artifactId>some-public-lib</artifactId>
+  <version>1.0</version>
+  <name>some-public-lib</name>
+  <description/>
+  <url>unknown</url>
+  <scm>
+    <url>unknown</url>
+  </scm>
+  <inceptionYear>2009</inceptionYear>
+  <licenses>
+    <license>
+      <name>Elastic License 2.0</name>
+      <url>https://raw.githubusercontent.com/elastic/elasticsearch/v1.0/licenses/ELASTIC-LICENSE-2.0.txt</url>
+      <distribution>repo</distribution>
+    </license>
+    <license>
+      <name>GNU Affero General Public License Version 3</name>
+      <url>https://raw.githubusercontent.com/elastic/elasticsearch/v1.0/licenses/AGPL-3.0+SSPL-1.0+ELASTIC-LICENSE-2.0.txt</url>
+      <distribution>repo</distribution>
+    </license>
+    <license>
+      <name>Server Side Public License, v 1</name>
+      <url>https://www.mongodb.com/licensing/server-side-public-license</url>
+      <distribution>repo</distribution>
+    </license>
+  </licenses>
+  <developers>
+    <developer>
+      <name>Elastic</name>
+      <url>https://www.elastic.co</url>
+    </developer>
+  </developers>
+</project>
+""")
+        assertXmlEquals(zip.file("org/acme/xpack/some-other-lib/1.0/some-other-lib-1.0.pom").read(),"""
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <!-- This module was also published with a richer model, Gradle metadata,  -->
+  <!-- which should be used instead. Do not delete the following line which  -->
+  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
+  <!-- that they should prefer consuming it instead. -->
+  <!-- do_not_remove: published-with-gradle-metadata -->
+  <modelVersion>4.0.0</modelVersion>
+  <groupId>org.acme.xpack</groupId>
+  <artifactId>some-other-lib</artifactId>
+  <version>1.0</version>
+  <name>some-other-lib</name>
+  <description/>
+  <url>unknown</url>
+  <scm>
+    <url>unknown</url>
+  </scm>
+  <inceptionYear>2009</inceptionYear>
+  <licenses>
+    <license>
+      <name>Elastic License 2.0</name>
+      <url>https://raw.githubusercontent.com/elastic/elasticsearch/v1.0/licenses/ELASTIC-LICENSE-2.0.txt</url>
+      <distribution>repo</distribution>
+    </license>
+    <license>
+      <name>GNU Affero General Public License Version 3</name>
+      <url>https://raw.githubusercontent.com/elastic/elasticsearch/v1.0/licenses/AGPL-3.0+SSPL-1.0+ELASTIC-LICENSE-2.0.txt</url>
+      <distribution>repo</distribution>
+    </license>
+    <license>
+      <name>Server Side Public License, v 1</name>
+      <url>https://www.mongodb.com/licensing/server-side-public-license</url>
+      <distribution>repo</distribution>
+    </license>
+  </licenses>
+  <developers>
+    <developer>
+      <name>Elastic</name>
+      <url>https://www.elastic.co</url>
+    </developer>
+  </developers>
+</project>
+""")
+}
+
 def "artifacts and tweaked pom is published"() {
     given:
     buildFile << """
@@ -520,4 +723,5 @@ $expected
     assert diff.hasDifferences() == false
     true
 }
+
 }

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BuildPlugin.java

@@ -9,6 +9,7 @@
 
 package org.elasticsearch.gradle.internal;
 
+import org.elasticsearch.gradle.internal.conventions.LicensingPlugin;
 import org.elasticsearch.gradle.internal.info.GlobalBuildInfoPlugin;
 import org.elasticsearch.gradle.internal.precommit.InternalPrecommitTasks;
 import org.elasticsearch.gradle.internal.snyk.SnykDependencyMonitoringGradlePlugin;
@@ -59,9 +60,9 @@ public void apply(final Project project) {
         }
 
         project.getPluginManager().apply("elasticsearch.java");
-        project.getPluginManager().apply("elasticsearch.publish");
         project.getPluginManager().apply(ElasticsearchJavadocPlugin.class);
         project.getPluginManager().apply(DependenciesInfoPlugin.class);
+        project.getPluginManager().apply(LicensingPlugin.class);
         project.getPluginManager().apply(SnykDependencyMonitoringGradlePlugin.class);
         project.getPluginManager().apply(ClusterFeaturesMetadataPlugin.class);
         InternalPrecommitTasks.create(project, true);

build-tools/src/testFixtures/groovy/org/elasticsearch/gradle/fixtures/AbstractGradleFuncTest.groovy

@@ -10,6 +10,7 @@
 package org.elasticsearch.gradle.fixtures
 
 import org.apache.commons.io.FileUtils
+import org.apache.commons.io.IOUtils
 import org.elasticsearch.gradle.internal.test.BuildConfigurationAwareGradleRunner
 import org.elasticsearch.gradle.internal.test.InternalAwareGradleRunner
 import org.elasticsearch.gradle.internal.test.NormalizeOutputGradleRunner
@@ -23,11 +24,14 @@ import spock.lang.Specification
 import spock.lang.TempDir
 
 import java.lang.management.ManagementFactory
+import java.nio.charset.StandardCharsets
 import java.nio.file.Files
 import java.io.File
 import java.nio.file.Path
 import java.util.jar.JarEntry
 import java.util.jar.JarOutputStream
+import java.util.zip.ZipEntry
+import java.util.zip.ZipFile
 
 import static org.elasticsearch.gradle.internal.test.TestUtils.normalizeString
 
@@ -234,6 +238,64 @@ checkstyle = "com.puppycrawl.tools:checkstyle:10.3"
                 (it as TestResultExtension.ErrorListener).errorInfo != null }
     }
 
+    ZipAssertion zip(String relativePath) {
+        File archiveFile = file(relativePath);
+        try (ZipFile zipFile = new ZipFile(archiveFile)) {
+            Map<String, ZipAssertionFile> files = zipFile.entries().collectEntries { ZipEntry entry ->
+                [(entry.name): new ZipAssertionFile(archiveFile, entry)]
+            }
+            return new ZipAssertion(files);
+        }
+    }
+
+    static class ZipAssertion {
+        private Map<String, ZipAssertionFile> files = new HashMap<>()
+
+        ZipAssertion(Map<String, ZipAssertionFile> files) {
+            this.files = files;
+        }
+
+        ZipAssertionFile file(String path) {
+            return this.files.get(path)
+        }
+
+        Collection<ZipAssertionFile> files() {
+            return files.values()
+        }
+    }
+
+    static class ZipAssertionFile {
+
+        private ZipEntry entry;
+        private File zipFile;
+
+        ZipAssertionFile(File zipFile, ZipEntry entry) {
+            this.entry = entry
+            this.zipFile = zipFile
+        }
+
+        boolean exists() {
+            entry == null
+        }
+
+        String getName() {
+            return entry.name
+        }
+
+        boolean isDirectory() {
+            return entry.isDirectory()
+        }
+
+        String read() {
+            try(ZipFile zipFile1 = new ZipFile(zipFile)) {
+                def inputStream = zipFile1.getInputStream(entry)
+                return IOUtils.toString(inputStream, StandardCharsets.UTF_8.name())
+            } catch (IOException e) {
+                throw new RuntimeException("Failed to read entry ${entry.name} from zip file ${zipFile.name}", e)
+            }
+        }
+    }
+
     static class ProjectConfigurer {
         private File projectDir