Skip to content

Update transport.asciidoc #103182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.11
Choose a base branch
from
Open

Update transport.asciidoc #103182

wants to merge 1 commit into from

Conversation

lhirlimann
Copy link
Member

Add an example on what to change to the unix configuration for having long keep_alive sessions.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

Add an example on what to change to the unix configuration for having long keep_alive sessions.
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Documentation preview:

@lhirlimann lhirlimann added the >docs General docs changes label Dec 8, 2023
@elasticsearchmachine
Copy link
Collaborator

@lhirlimann please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team v8.11.3 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 8, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@lhirlimann
Copy link
Member Author

@lhirlimann please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

Can't find how to do it since I don't have a fork, I used the UI from the docs page to make the edit.

@leemthompo
Copy link
Contributor

@DaveCTurner any SME input on this one? :)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we write this similarly to how it's done on https://www.elastic.co/guide/en/elasticsearch/reference/current/system-config-tcpretries.html?

Also I don't think we should be suggesting changing tcp_keepalive_probes.

@leemthompo
Copy link
Contributor

Important

Elastic documentation is migrating to Markdown for version 9.0+. See the migration guide for details.

ℹ️ What's happening?

  • Starting January 29, we will start closing all unmerged documentation PRs targeting main/master
  • We're migrating from AsciiDoc to Markdown for 9.0+
  • 9.0 docs will be frozen from January 29 until February 20 2024
  • NOTE: PRs that include both code and documentation changes will remain open

What do I need to do?

For <=8.x docs:

  1. Rebase your PR to target the relevant 8.x branch instead
  2. The content can remain in AsciiDoc format

For 9.0+ docs:

Option 1:

  • Draft docs in Markdown
  • Once migration freeze ends, find the relevant page in the new docs system and use the edit options to submit your changes

Option 2:

💡 Need help?

  1. For Elasticians: Ask in #docs Slack channel
  2. For external contributors: Open an issue in elastic/docs-content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.11.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants