Skip to content

Update datehistogram-aggregation.asciidoc #102234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.11
Choose a base branch
from

Conversation

jmucero97
Copy link

There is an error on the sign of the timezone, when we're in UTC - 1, our midnight occurs 1h AFTER midnight in UTC.

For the statement to be correct, it should be in UTC + 1 (Timezone of Madrid in winter)

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

There is an error on the sign of the timezone, when we're in UTC - 1, our midnight occurs 1h AFTER midnight in UTC. 

For the statement to be correct, it should be in UTC + 1 (Timezone of Madrid in winter)
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
8b60101

Please, read and sign the above mentioned agreement if you want to contribute to this project

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.11.2 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 15, 2023
@abdonpijpelink abdonpijpelink added >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Nov 21, 2023
@abdonpijpelink abdonpijpelink self-assigned this Nov 21, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Nov 21, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@abdonpijpelink
Copy link
Contributor

@jmucero97 Thank you for contributing to the Elasticsearch documentation! Would you mind signing the contributor agreement, so we can accept your contribution?

@leemthompo
Copy link
Contributor

Important

Elastic documentation is migrating to Markdown for version 9.0+. See the migration guide for details.

ℹ️ What's happening?

  • Starting January 29, we will start closing all unmerged documentation PRs targeting main/master
  • We're migrating from AsciiDoc to Markdown for 9.0+
  • 9.0 docs will be frozen from January 29 until February 20 2024
  • NOTE: PRs that include both code and documentation changes will remain open

What do I need to do?

For <=8.x docs:

  1. Rebase your PR to target the relevant 8.x branch instead
  2. The content can remain in AsciiDoc format

For 9.0+ docs:

Option 1:

  • Draft docs in Markdown
  • Once migration freeze ends, find the relevant page in the new docs system and use the edit options to submit your changes

Option 2:

💡 Need help?

  1. For Elasticians: Ask in #docs Slack channel
  2. For external contributors: Open an issue in elastic/docs-content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.11.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants