Skip to content

Commit 1abb006

Browse files
jan-elasticjan-elastic
authored
rename ES|QL sample capability (#129193)
1 parent 94e9513 commit 1abb006

File tree

7 files changed

+25
-25
lines changed

7 files changed

+25
-25
lines changed

‎x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/RestSampleTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class RestSampleTestCase extends ESRestTestCase {
3333
public void skipWhenSampleDisabled() throws IOException {
3434
assumeTrue(
3535
"Requires SAMPLE capability",
36-
EsqlSpecTestCase.hasCapabilities(adminClient(), List.of(EsqlCapabilities.Cap.SAMPLE.capabilityName()))
36+
EsqlSpecTestCase.hasCapabilities(adminClient(), List.of(EsqlCapabilities.Cap.SAMPLE_V2.capabilityName()))
3737
);
3838
}
3939

‎x-pack/plugin/esql/qa/testFixtures/src/main/resources/sample.csv-spec

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
// because the CSV tests don't support such assertions.
1010

1111
row
12-
required_capability: sample
12+
required_capability: sample_v2
1313

1414
ROW x = 1 | SAMPLE .999999999
1515
;
@@ -20,7 +20,7 @@ x:integer
2020

2121

2222
row and mv_expand
23-
required_capability: sample
23+
required_capability: sample_v2
2424

2525
ROW x = [1,2,3,4,5] | MV_EXPAND x | SAMPLE .999999999
2626
;
@@ -35,7 +35,7 @@ x:integer
3535

3636

3737
adjust stats for sampling
38-
required_capability: sample
38+
required_capability: sample_v2
3939

4040
FROM employees
4141
| SAMPLE 0.5
@@ -53,7 +53,7 @@ true
5353

5454

5555
before where
56-
required_capability: sample
56+
required_capability: sample_v2
5757

5858
FROM employees
5959
| SAMPLE 0.5
@@ -71,7 +71,7 @@ true
7171

7272

7373
after where
74-
required_capability: sample
74+
required_capability: sample_v2
7575

7676
FROM employees
7777
| WHERE emp_no <= 10050
@@ -89,7 +89,7 @@ true
8989

9090

9191
before sort
92-
required_capability: sample
92+
required_capability: sample_v2
9393

9494
FROM employees
9595
| SAMPLE 0.5
@@ -107,7 +107,7 @@ true
107107

108108

109109
after sort
110-
required_capability: sample
110+
required_capability: sample_v2
111111

112112
FROM employees
113113
| SORT emp_no
@@ -125,7 +125,7 @@ true
125125

126126

127127
before limit
128-
required_capability: sample
128+
required_capability: sample_v2
129129

130130
FROM employees
131131
| SAMPLE 0.5
@@ -141,7 +141,7 @@ true
141141

142142

143143
after limit
144-
required_capability: sample
144+
required_capability: sample_v2
145145

146146
FROM employees
147147
| LIMIT 50
@@ -158,7 +158,7 @@ true
158158

159159

160160
before mv_expand
161-
required_capability: sample
161+
required_capability: sample_v2
162162

163163
ROW x = [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50], y = [1,2]
164164
| MV_EXPAND x
@@ -176,7 +176,7 @@ true
176176

177177

178178
after mv_expand
179-
required_capability: sample
179+
required_capability: sample_v2
180180

181181
ROW x = [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50], y = [1,2]
182182
| MV_EXPAND x
@@ -194,7 +194,7 @@ true
194194

195195

196196
multiple samples
197-
required_capability: sample
197+
required_capability: sample_v2
198198

199199
FROM employees
200200
| SAMPLE 0.7
@@ -213,7 +213,7 @@ true
213213

214214

215215
after stats
216-
required_capability: sample
216+
required_capability: sample_v2
217217

218218
FROM employees
219219
| SAMPLE 0.5

‎x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1077,7 +1077,7 @@ public enum Cap {
10771077
/**
10781078
* Support for the SAMPLE command
10791079
*/
1080-
SAMPLE(Build.current().isSnapshot()),
1080+
SAMPLE_V2(Build.current().isSnapshot()),
10811081

10821082
/**
10831083
* The {@code _query} API now gives a cast recommendation if multiple types are found in certain instances.

‎x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3460,7 +3460,7 @@ public void testRrfError() {
34603460
}
34613461

34623462
public void testRandomSampleProbability() {
3463-
assumeTrue("requires SAMPLE capability", EsqlCapabilities.Cap.SAMPLE.isEnabled());
3463+
assumeTrue("requires SAMPLE capability", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
34643464

34653465
var e = expectThrows(VerificationException.class, () -> analyze("FROM test | SAMPLE 1."));
34663466
assertThat(e.getMessage(), containsString("RandomSampling probability must be strictly between 0.0 and 1.0, was [1.0]"));

‎x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LogicalPlanOptimizerTests.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7858,7 +7858,7 @@ public void testPruneRedundantOrderBy() {
78587858
* \_EsRelation[test][_meta_field{f}#12, emp_no{f}#6, first_name{f}#7, ge..]
78597859
*/
78607860
public void testSampleMerged() {
7861-
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE.isEnabled());
7861+
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
78627862

78637863
var query = """
78647864
FROM TEST
@@ -7879,7 +7879,7 @@ public void testSampleMerged() {
78797879
}
78807880

78817881
public void testSamplePushDown() {
7882-
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE.isEnabled());
7882+
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
78837883

78847884
for (var command : List.of(
78857885
"ENRICH languages_idx on first_name",
@@ -7904,7 +7904,7 @@ public void testSamplePushDown() {
79047904
}
79057905

79067906
public void testSamplePushDown_sort() {
7907-
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE.isEnabled());
7907+
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
79087908

79097909
var query = "FROM TEST | WHERE emp_no > 0 | SAMPLE 0.5 | LIMIT 100";
79107910
var optimized = optimizedPlan(query);
@@ -7918,7 +7918,7 @@ public void testSamplePushDown_sort() {
79187918
}
79197919

79207920
public void testSamplePushDown_where() {
7921-
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE.isEnabled());
7921+
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
79227922

79237923
var query = "FROM TEST | SORT emp_no | SAMPLE 0.5 | LIMIT 100";
79247924
var optimized = optimizedPlan(query);
@@ -7931,7 +7931,7 @@ public void testSamplePushDown_where() {
79317931
}
79327932

79337933
public void testSampleNoPushDown() {
7934-
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE.isEnabled());
7934+
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
79357935

79367936
for (var command : List.of("LIMIT 100", "MV_EXPAND languages", "STATS COUNT()")) {
79377937
var query = "FROM TEST | " + command + " | SAMPLE .5";
@@ -7953,7 +7953,7 @@ public void testSampleNoPushDown() {
79537953
* \_EsRelation[languages_lookup][LOOKUP][language_code{f}#17, language_name{f}#18]
79547954
*/
79557955
public void testSampleNoPushDownLookupJoin() {
7956-
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE.isEnabled());
7956+
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
79577957

79587958
var query = """
79597959
FROM TEST
@@ -7979,7 +7979,7 @@ public void testSampleNoPushDownLookupJoin() {
79797979
* \_EsRelation[test][_meta_field{f}#12, emp_no{f}#6, first_name{f}#7, ge..]
79807980
*/
79817981
public void testSampleNoPushDownChangePoint() {
7982-
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE.isEnabled());
7982+
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
79837983

79847984
var query = """
79857985
FROM TEST

‎x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/PhysicalPlanOptimizerTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8045,7 +8045,7 @@ public void testNotEqualsPushdownToDelegate() {
80458045
* [_doc{f}#24], limit[1000], sort[] estimatedRowSize[332]
80468046
*/
80478047
public void testSamplePushDown() {
8048-
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE.isEnabled());
8048+
assumeTrue("sample must be enabled", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
80498049

80508050
var plan = physicalPlan("""
80518051
FROM test

‎x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3482,7 +3482,7 @@ public void testInvalidCompletion() {
34823482
}
34833483

34843484
public void testSample() {
3485-
assumeTrue("SAMPLE requires corresponding capability", EsqlCapabilities.Cap.SAMPLE.isEnabled());
3485+
assumeTrue("SAMPLE requires corresponding capability", EsqlCapabilities.Cap.SAMPLE_V2.isEnabled());
34863486
expectError("FROM test | SAMPLE .1 2", "line 1:23: extraneous input '2' expecting <EOF>");
34873487
expectError("FROM test | SAMPLE .1 \"2\"", "line 1:23: extraneous input '\"2\"' expecting <EOF>");
34883488
expectError("FROM test | SAMPLE 1", "line 1:20: mismatched input '1' expecting {DECIMAL_LITERAL, '+', '-'}");

0 commit comments

Comments
 (0)