Add flag to signal disconnection, as assignment to the needs_reconnect flag can race with on_error.

Author: tomwilkie

pusherclient/connection.py

@@ -19,6 +19,7 @@ def __init__(self, event_handler, url, log_level=logging.INFO, daemon=True):
 
         self.event_callbacks = {}
 
+        self.disconnect_called = False
         self.needs_reconnect = False
         self.reconnect_interval = 10
 
@@ -73,6 +74,7 @@ def bind(self, event_name, callback):
 
     def disconnect(self):
         self.needs_reconnect = False
+        self.disconnect_called = True
         if self.socket:
             self.socket.close()
         self.join()
@@ -101,7 +103,7 @@ def _connect(self):
 
         self.socket.run_forever()
 
-        while self.needs_reconnect:
+        while self.needs_reconnect and not self.disconnect_called:
             self.logger.info("Attempting to connect again in %s seconds."
                              % self.reconnect_interval)
             self.state = "unavailable"