Skip to content

Commit d0ac3b0

Browse files
authored
Merge pull request #65 from wetcoastdev/master
Downloading PDF in python3
2 parents 665621d + a83f328 commit d0ac3b0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

quickbooks/mixins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ class QuickbooksPdfDownloadable(object):
163163
qbo_object_name = ""
164164

165165
def download_pdf(self, qb=None):
166-
if self.Id and self.Id > 0 and qb is not None:
166+
if self.Id and int(self.Id) > 0 and qb is not None:
167167
return qb.download_pdf(self.qbo_object_name, self.Id)
168168
else:
169169
raise QuickbooksException(

tests/unit/test_mixins.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,10 @@ def setUp(self):
209209
@patch('quickbooks.client.QuickBooks.download_pdf')
210210
def test_download_invoice(self, download_pdf):
211211
receipt = SalesReceipt()
212-
receipt.Id = 1
212+
receipt.Id = "1"
213213

214214
receipt.download_pdf(self.qb_client)
215-
download_pdf.assert_called_once_with('SalesReceipt', 1)
215+
download_pdf.assert_called_once_with('SalesReceipt', "1")
216216

217217
def test_download_missing_id(self):
218218
from quickbooks.exceptions import QuickbooksException

0 commit comments

Comments
 (0)