Fix memoization

Author: ehmicky

src/cache/clone.js

@@ -1,7 +1,14 @@
 // Clone cached versions to prevent mutations
 // TODO: use `structuredClone()` after dropping support for Node <17.0.0
 export const cloneCachedVersions = function ({ versions, majors }) {
-  return { versions: [...versions], majors: majors.map(shallowCloneObject) }
+  return {
+    versions: shallowCloneObjectsArray(versions),
+    majors: shallowCloneObjectsArray(majors),
+  }
+}
+
+const shallowCloneObjectsArray = function (arrayOfObjects) {
+  return arrayOfObjects.map(shallowCloneObject)
 }
 
 const shallowCloneObject = function (object) {

test/cache.js

@@ -79,9 +79,13 @@ each(
 
 test.serial(`Process cached files cannot be mutated`, async (t) => {
   const { versions } = await allNodeVersions({ fetch: false })
-  const [firstVersion] = versions
+  const [{ node: firstVersion }] = versions
+  // eslint-disable-next-line fp/no-mutation
+  versions[0].node = 'test'
   // eslint-disable-next-line fp/no-mutating-methods
   versions.reverse()
-  const { versions: versionsAgain } = await allNodeVersions({ fetch: false })
-  t.is(versionsAgain[0], firstVersion)
+  const {
+    versions: [{ node: firstVersionAgain }],
+  } = await allNodeVersions({ fetch: false })
+  t.is(firstVersionAgain, firstVersion)
 })

test/helpers/cache.js

@@ -19,7 +19,7 @@ export const writeCacheFile = async function (oldCacheFile = false) {
   const cacheFile = await getCacheFile()
   const lastUpdate = oldCacheFile ? 0 : Date.now()
   const versionsInfo = {
-    versions: ['cached'],
+    versions: [{ node: 'cached' }],
     majors: [{ major: 1, latest: 'cached' }],
   }
   const cacheContent = { lastUpdate, ...versionsInfo }

test/helpers/main.js

@@ -3,7 +3,7 @@ import allNodeVersions from 'all-node-versions'
 // Retrieve latest Node.js version
 export const getLatestVersion = async function (opts) {
   const {
-    versions: [version],
+    versions: [{ node }],
   } = await allNodeVersions(opts)
-  return version
+  return node
 }